sources: fix ignore patterns in local sources
Metadata
Current evaluation
Merged as 722d8f57; local sources no longer accumulate repeated ignore patterns. Backported to 1.18 by #373 (ec0ab362).
Resolution: closed resolved
Reason: #362 was merged as commit 722d8f57, fixing cumulative ignore-pattern list construction for local sources. #373 merged the same fix as ec0ab362 for the 1.18 branch.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Don't create a cumulative list of patterns to ignore when processing local sources, or the list can become quite large with repetitions of the same patterns.
This can be further refactored to rename confusing variable names and remove unused code. This commit only fixes the cumulative list building issue, other issues will be addressed in separate PRs.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 722d8f57; local sources no longer accumulate repeated ignore patterns. Backported to 1.18 by #373 (ec0ab362). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-parts#362 via commit 722d8f57, fixing local-source ignore handling to avoid accumulating repeated patterns. Backported to 1.18 in #373 (ec0ab362). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for local source ignore patterns. Prevents cumulative list buildup and repetitions. Approved by one reviewer, passed CI, and committed with 21 additions and 6 deletions across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing cumulative ignore pattern lists in local sources, eliminating repetitive entries. The change stops pattern accumulation during processing, with further code cleanup deferred to separate updates. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-parts#373
(confidence 99%)
Merged backport of #362 to the 1.18 branch as ec0ab362.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #373 sources: fix ignore patterns in local sources | craft-parts | merged | Merged backport PR #373 (commit ec0ab362) porting #362 to the 1.18 branch: local sources no longer accumulate a growing, repetitive ignore-pattern list. | |
| #363 sources: fix ignore patterns in local sources | craft-parts | merged | Merged PR #363, preventing local-source processing from accumulating repeated ignore patterns; the fix landed as 722d8f57 and was later backported by #373. | |
| #96 many: fix source ignore patterns (CRAFT-375) | craft-parts | merged | Merged #96 via commit 9fd6ee7c (merge ab69ef78), fixing local-source filtering to exclude generated outputs, support app-defined ignore patterns, and honor custom work directories. | |
| #375 Release 1.18.1 | craft-parts | merged | Merged release PR #375 as commit 7d99fbe6, publishing v1.18.1 with the local-source ignore-pattern fix backported by #373. | |
| #369 Release 1.15.3 | craft-parts | merged | Merged as release 1.15.3, backporting the local-source ignore-pattern fix from #362 to the 1.15 maintenance line. | |
| #425 Release 1.19.2 | craft-parts | merged | Merged release 1.19.2 in #425 (commit 8e3ca2bb), fixing ignored-file exclusion for local sources. | |
| #376 Merge/1.18.1 | craft-parts | merged | PR #376 merged (commit 074d654f) backporting release 1.18.1 to main, including the local-source ignore-pattern fix; hotfix-only pinned linters were intentionally left out. | |
| #120 sources: copy mutable ignore pattern for source handlers (CRAFT-494) | craft-parts | merged | Merged PR #120 (CRAFT-494, cmatsuoka) fixed shared mutable ignore patterns: merge commit 880735ee, implementation commit 280e1592, approved by 2 reviewers with no unresolved comments. |