sources: fix ignore patterns in local sources
Metadata
Current evaluation
Merged fix for local source ignore patterns. Prevents cumulative list buildup and repetitions. Approved by one reviewer, passed CI, and committed with 21 additions and 6 deletions across two files.
Suggested action: —
No scores available.
Issue body
Don't create a cumulative list of patterns to ignore when processing local sources, or the list can become quite large with repetitions of the same patterns.
This can be further refactored to rename confusing variable names and remove unused code. This commit only fixes the cumulative list building issue, other issues will be addressed in separate PRs.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for local source ignore patterns. Prevents cumulative list buildup and repetitions. Approved by one reviewer, passed CI, and committed with 21 additions and 6 deletions across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing cumulative ignore pattern lists in local sources, eliminating repetitive entries. The change stops pattern accumulation during processing, with further code cleanup deferred to separate updates. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #363 sources: fix ignore patterns in local sources | craft-parts | merged | Merged fix for local source ignore patterns that prevented cumulative list creation, eliminating repetitions and excessive size. Approved by reviewer, passed CI, and modified 2 files (+21/-6). | |
| #373 sources: fix ignore patterns in local sources | craft-parts | merged | Merged fix for local source ignore patterns to prevent cumulative and repetitive lists. This backport of #362 to the 1.18 branch optimizes pattern processing, received approval, and passed CI checks. | |
| #96 many: fix source ignore patterns (CRAFT-375) | craft-parts | merged | Merged fix for source ignore patterns preventing locally generated files from being pulled as sources. Updates allow custom ignore patterns for outputs and correctly ignore work directories. Approved by two reviewers with passing CI checks. | |
| #369 Release 1.15.3 | craft-parts | merged | Merged release 1.15.3, backporting a fix for local sources ignore patterns. Approved by one reviewer, passed CI checks, and updated five files. | |
| #375 Release 1.18.1 | craft-parts | merged | Merged release 1.18.1, fixing ignore patterns in local sources. Approved by two reviewers and passed CI checks before integration. | |
| #322 sources: improve missing local source error message | craft-parts | merged | Merged. Updates error handling to display a clear source not found message instead of a file copy error when a local source is missing. Approved by two reviewers, passed CI, and changed 17 lines across two files. | |
| #425 Release 1.19.2 | craft-parts | merged | Merged Release 1.19.2 containing a changelog fix for ignored files exclusion in local source. Approved by one reviewer and successfully merged. |