← Back to issue list

feat: allow hyphens in partition names

View original Github issue

Metadata

Project
craft-parts
Number
#800
Type
pull request
State
merged
Author
mattculler
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #800 as commit 184d5142, adding support for hyphens in partition names for CRAFT-3031.

Resolution: closed resolved

Reason: PR #800 was approved and merged as commit 184d5142, directly implementing hyphen support in partition names.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- (CRAFT-3031)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #800 as commit 184d5142, adding support for hyphens in partition names for CRAFT-3031.
stealth/space-bunny-alpha — closed resolved Merged as commit 184d5142, adding support for hyphens in partition names for CRAFT-3031.
qwen/qwen3.6-35b-a3b — — Merged to allow hyphens in partition names. Approved by two reviewers, the change updates five files with 85 additions and 51 deletions, resolving CRAFT-3031.
qwen3.6-35b-a3b-mtp-q6 — — Merged a feature enabling hyphens in partition names, addressing CRAFT-3031. Authored by maintainer mattculler, the change was merged without additional comments.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#801 (confidence 95%)

    Follow-up PR #801 merged as commit ceaf4cda to fix lifecycle handling of partition names containing numbers and hyphens.

Related issues

Issue Project State Summary Similarity
#1002 feat: Allow slashes in partition names craft-parts merged Merged as c2e41898, allowing slashes in partition names and fixing #999 (CRAFT-4064).
83%
#789 Allow hyphens in partition names craft-parts closed Hyphens enabled in partition names and namespace/partition overlap conflicts validated. Landed via merged PR canonical/craft-parts#800 (commit 184d5142); conflict detection lives in _detect_conflicts().
82%
#790 feat: allow numbers in partition names and namespaces craft-parts merged Merged PR #790 (commit b2128938) relaxes partition/namespace name validation to allow numbers; unblocked LP#2069783 (CRAFT-3043). Follow-up for hyphens filed as #789, fixed later by #800.
81%
#801 fix: partitions break when using special characters craft-parts merged Merged PR #801 fixed CRAFT-3031 lifecycle failures for partition names containing numbers and hyphens; merged as commit ceaf4cda.
80%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged into main in commit f387afa5 (PR #600), adding namespaced-partition handling to four partition utilities and resolving craft-parts#596.
74%
#683 Feature/namespaced partitions craft-parts closed Namespaced-partition support was merged via PR #684 (commit 188d9166) and released in craft-parts 1.28.0.
72%
#497 partitions: add utility to make partition compatible filepaths craft-parts merged Merged #497, adding a utility that converts filepaths into partition-compatible paths for CRAFT-1845; landed as commit 20e994f8.
72%
#1110 feat: cleaning with partitions craft-parts merged Merged PR #1110 adds partition-aware cleanup of shared areas for CRAFT-4585, following prerequisite #1109; it is recorded on main as commit 0584c19c.
72%
#1612 feat: allow the plus sign in partition names craft-parts merged Merged PR #1612 as commit 5d5b792a, expanding partition-name validation to permit plus signs used by .deb package names.
71%
#1035 feat: reconcile overlays and partition features craft-parts merged Merged PR #1035 at commit b575539e, enabling overlay and partition features simultaneously and fixing canonical/craft-parts#1028.
70%