← Back to issue list

feat: add stage-slices key

View original Github issue

Metadata

Project
craft-parts
Number
#1669
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Squash merged adding the stage-slices key per ST179. Implements validation and deprecation warning logic split between craft-parts and craft-application. Approved by three reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`?https://docs.google.com/document/d/1tQUv6iMq06uq5-dMPAX0qnOr0Qx0NASA7aceuoZUc-I/edit?tab=t.0 - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Adds a `stage-slices` key per [ST179](https://docs.google.com/document/d/1tQUv6iMq06uq5-dMPAX0qnOr0Qx0NASA7aceuoZUc-I/edit?tab=t.0). Split into 3 commits for your reviewing pleasure. This is how I understood the division of responsibility between craft-parts and craft-application/downstream apps: #### craft-parts - All validation and errors related to defining slices in `stage-packages` and `stage-slices`. #### craft-application - Deprecation warnings about using slices in `stage-packages`. - Deciding when to allow slices in `stage-packages`. (CRAFT-5253)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Squash merged adding the stage-slices key per ST179. Implements validation and deprecation warning logic split between craft-parts and craft-application. Approved by three reviewers and passed CI checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 65
Confidence: 90
needs review Adds a stage-slices key per ST179, clarifying validation responsibilities between craft-parts and craft-application. Approved by three reviewers, CI passing, and ready for merge.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 45
Confidence: 90
needs review Adds stage-slices key per ST179, clarifying validation responsibilities between craft-parts and craft-application. Approved by three reviewers, awaiting CI completion.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Adds a stage-slices key to craft-parts per ST179, clarifying validation responsibilities. Approved by 3 reviewers with zero unresolved comments. CI tests are currently pending.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 60
Confidence: 85
needs review Adds a stage-slices key to craft-parts, clarifying validation responsibilities for slices. Approved by three reviewers with no unresolved comments, but multiple slow tests are failing across architectures and Python versions.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 40
Confidence: 85
needs review Adds stage-slices key per ST179, splitting validation between craft-parts and craft-application. Approved by 3 reviewers but has 3 unresolved comments and 4 failing Java plugin tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Adds a stage-slices key to implement ST179 and clarifies validation responsibilities between craft-parts and craft-application. Currently approved by three reviewers but has three unresolved comments and four failing CI checks on Java plugin tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Adds a stage-slices key per ST179, splitting validation and deprecation logic between craft-parts and craft-application. Approved by one reviewer with three unresolved comments and four failing Java plugin CI tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 50
Confidence: 85
needs review Adds a stage-slices key to support ST179, clarifying validation responsibilities between craft-parts and craft-application. Currently approved by one reviewer with four unresolved comments and pending CI tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 50
Confidence: 85
needs review Adds a stage-slices key per ST179, splitting validation between craft-parts and craft-application. Approved by one reviewer with five unresolved comments and one failing CI job.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Adds a stage-slices key per ST179, clarifying validation responsibilities between craft-parts and craft-application. Approved by one reviewer, pending resolution of 3 comments and a failing CI job.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 40
Confidence: 95
needs review Adds a stage-slices configuration key to craft-parts per ST179, splitting validation and deprecation logic between packages. Currently pending review with changes requested and unresolved comments.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 65
Confidence: 90
needs review Adds stage-slices key per ST179, splitting validation between craft-parts and craft-application. Currently has changes_requested status with 5 unresolved review comments. CI passing except pending slow tests.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 45
Confidence: 90
needs review Adds a stage-slices key per ST179, clarifying validation responsibilities between craft-parts and craft-application. Currently has 7 unresolved review comments requesting changes, with all CI checks passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Adds a stage-slices key per ST179, reorganizing validation and deprecation logic between craft-parts and craft-application. Currently pending maintainer review with 8 unresolved comments and all CI checks passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Adds a stage-slices key to craft-application per ST179, splitting validation and deprecation logic between craft-parts and downstream apps. Currently pending maintainer review with 4 unresolved comments and all CI checks passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Introduces a stage-slices key and associated validation logic per ST179. Currently awaiting maintainer review with 3 unresolved comments and several CI checks still pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 55
Confidence: 90
needs review Adds a stage-slices key to support ST179, splitting validation logic between craft-parts and craft-application. Currently pending maintainer review with all CI checks passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Adds a stage-slices key per ST179, splitting validation logic between craft-parts and craft-application. Currently pending maintainer review with one unresolved comment and all CI checks passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Adds a stage-slices key per ST179, clarifying validation responsibilities between craft-parts and craft-application. Currently pending maintainer review with all CI checks passing and one unresolved comment.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Adds a stage-slices key to support ST179, clarifying validation responsibilities between craft-parts and craft-application. Currently pending maintainer review with passing CI checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 65
Confidence: 85
needs review Adds a stage-slices key per ST179, splitting validation logic between craft-parts and craft-application. Currently pending maintainer review with all required CI checks passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Adds a stage-slices key per ST179, clarifying validation responsibilities between craft-parts and craft-application. Currently pending maintainer review with all CI checks passing or pending.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#279 spec: add "stage-slices" for chisel slices craft-parts merged Merged the addition of a stage-slices specification to handle chisel slice naming conventions, which require underscores unlike standard .deb packages. Approved by one reviewer, modified two files, and resolved CRAFT-1329.
74%