← Back to issue list

spec: add "stage-slices" for chisel slices

View original Github issue

Metadata

Project
craft-parts
Number
#279
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged the addition of a stage-slices specification to handle chisel slice naming conventions, which require underscores unlike standard .deb packages. Approved by one reviewer, modified two files, and resolved CRAFT-1329.

Suggested action:

No scores available.

Issue body

The slices are defined in the regular "stage-packages" by virtue of the fact that .deb package names *cannot* have underscores while chisel slices *must always* have an underscore to distinguish between package name and the specific slice. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- (CRAFT-1329)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the addition of a stage-slices specification to handle chisel slice naming conventions, which require underscores unlike standard .deb packages. Approved by one reviewer, modified two files, and resolved CRAFT-1329.
qwen3.6-35b-a3b-mtp-q6 Merged the addition of a stage-slices specification to handle chisel slice naming conventions, resolving CRAFT-1329. The change defines slices within stage-packages to accommodate mandatory underscores in chisel slice identifiers.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#904 feat: add chisel as a build snap when stage-packages contain slices craft-parts merged Merged. Conditionally installs chisel as a build snap only when stage-packages contain slices and no part already declares it, preventing unnecessary installation in the Rockcraft snap. Approved by two reviewers and passed CI.
76%
#84 Add chisel to rockcraft rockcraft merged Merged after approval and passing CI. Integrated chisel into rockcraft to support chisel slices in stage-packages. Temporarily pinned craft-parts to a main branch commit pending an official release. Added a spread test for the dotnet-runtime-6.0_libs slice.
74%
#649 Install chisel if parts use slices craft-parts closed Automatically installs chisel when parts declare slices in stage-packages. Resolved and merged via pull request #904, centralizing the tool management within craft-parts.
74%
#1669 feat: add stage-slices key craft-parts merged Squash merged adding the stage-slices key per ST179. Implements validation and deprecation warning logic split between craft-parts and craft-application. Approved by three reviewers and passed CI checks.
74%
#590 fix(deb): normalize chisel slices craft-parts closed Merged fix normalizing chisel slices during deb unpacking to correct absolute symlinks, resolving issue #578. Approved by two reviewers with passing CI checks.
73%
#592 fix(deb): normalize chisel slices craft-parts merged Merged. Normalizes chisel slices during deb unpacking to fix absolute symlinks and prevent external path references. Resolves #578. Approved by two reviewers and passed CI.
73%
#1715 refactor: put chisel call in its own module craft-parts merged Merged refactoring that extracts the chisel call into a dedicated module, decoupling slice cutting from path normalization to support upcoming build-slices changes. Approved by two reviewers.
73%
#4260 Allow chiseled stage-packages snapcraft closed Implemented chiseled stage-packages support in snapcraft 8, allowing chisel slices to reduce unneeded files and deduplicate packaging work.
72%
#1717 feat(part): add build-slices model craft-parts closed Merged the addition of a build-slices Part property listing Chisel slices for the build root. The change introduces a new feature flag and validation logic. Approved by a reviewer and passed all CI checks.
72%
#281 unpack chisel slices craft-parts merged Merged implementation to unpack chisel slices via PullState routing from pull to build step. Updated CI Go version, added integration tests, and verified locally. Approved by two reviewers, +365/-66 lines across 8 files.
71%