packages: address issues raised by pyright 1.1.151 (CRAFT-303)
Metadata
Current evaluation
Merged to address pyright 1.1.151 warnings for None indexing across four files. Approved by two reviewers and passing CI, the changes fix type checking issues previously ignored by older versions.
Suggested action: —
No scores available.
Issue body
Pyright 1.1.151 warns about many instances of None indexing that were
ignored by previous versions, address them.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to address pyright 1.1.151 warnings for None indexing across four files. Approved by two reviewers and passing CI, the changes fix type checking issues previously ignored by older versions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes addressing None indexing warnings introduced by pyright 1.1.151 across packages. Resolved type checking issues to ensure compatibility with the updated static analysis tool. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #701 build(deps): update pyright to 1.1.358 | craft-parts | merged | Merged update to pyright version 1.1.358. Approved by two reviewers and passed CI. A lint issue was addressed separately in PR #702. The change modified three files with minimal adjustments. | |
| #1703 build: update pyright to 1.1.366 | charmcraft | merged | Merged update to pyright version 1.1.366. The change modified two files with a net reduction of five lines. Approved by one reviewer with no unresolved comments before integration. | |
| #177 linting: address pyright issues | craft-parts | merged | Merged following approval and passing CI. Updated type declarations to comply with Pyright 1.1.225 by adding Optional to None arguments and correcting callback type typos across 16 files. | |
| #342 type: fix pyright possibly-unbound error | rockcraft | merged | Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions. | |
| #4205 lint: fix for pyright 1.1.312 | snapcraft | merged | Merged a fix for type errors in account.py triggered by Pyright 1.1.312's stricter kwargs validation. The change corrects type annotations, passes CI, and was approved by a reviewer. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%. | |
| #237 style: fix pyright config | craft-cli | merged | Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated. | |
| #1525 build: enable pyright | charmcraft | merged | Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff. | |
| #515 build(deps): update pyright | craft-application | merged | Successfully merged pyright dependency update. Approved by two reviewers with no unresolved comments. Changes modify three files, adding five and removing three lines. | |
| #65 Fixed new pyright issues. | craft-cli | merged | Merged a maintainer-submitted pull request resolving newly identified pyright type checking issues. The change modified two lines in a single file, received one reviewer approval, and was successfully integrated into the codebase. |