packages: address issues raised by pyright 1.1.151 (CRAFT-303)
Metadata
Current evaluation
Merged PR #84 via a24147b5, applying 8aeb3ea8 to fix None-indexing warnings introduced by Pyright 1.1.151.
Resolution: closed resolved
Reason: PR #84 was approved and merged as a24147b5. Implementation commit 8aeb3ea8 updated four files to address the new CRAFT-303 warnings.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Pyright 1.1.151 warns about many instances of None indexing that were
ignored by previous versions, address them.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #84 via a24147b5, applying 8aeb3ea8 to fix None-indexing warnings introduced by Pyright 1.1.151. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #84 in commit a24147b5, implementing 8aeb3ea8 to address None-indexing warnings from Pyright 1.1.151 (CRAFT-303). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to address pyright 1.1.151 warnings for None indexing across four files. Approved by two reviewers and passing CI, the changes fix type checking issues previously ignored by older versions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes addressing None indexing warnings introduced by pyright 1.1.151 across packages. Resolved type checking issues to ensure compatibility with the updated static analysis tool. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #177 linting: address pyright issues | craft-parts | merged | Merged in craft-parts#177: updated type declarations for Pyright 1.1.225, added Optional for arguments that may be None, and fixed callback annotation typos. | |
| #342 type: fix pyright possibly-unbound error | rockcraft | merged | Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929. | |
| #1703 build: update pyright to 1.1.366 | charmcraft | merged | Merged PR #1703 upgraded Pyright to 1.1.366 in two build files via commit d189a48e. | |
| #65 Fixed new pyright issues. | craft-cli | merged | Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479). | |
| #701 build(deps): update pyright to 1.1.358 | craft-parts | merged | Merged the Pyright 1.1.358 dependency update in #701 as commit 9a30c724; follow-up lint issues were fixed by #702. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated. | |
| #1525 build: enable pyright | charmcraft | merged | Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption. |