fix: enable overlays in _enable_craft_parts_features()
Metadata
Current evaluation
Merged #602 (commit 86153dcc), enabling Craft Parts overlays during Rockcraft initialization via Features(enable_overlay=True).
Resolution: closed resolved
Reason: PR #602 was merged as commit 86153dcc, updating _enable_craft_parts_features() to initialize Features with enable_overlay=True.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #602 (commit 86153dcc), enabling Craft Parts overlays during Rockcraft initialization via Features(enable_overlay=True). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #602 in commit 86153dcc, enabling overlays when Rockcraft initializes Craft Parts features. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #602 via commit 86153dcc, enabling overlays in _enable_craft_parts_features() during Rockcraft initialization. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/rockcraft#602 via commit 86153dcc, enabling overlay support when Rockcraft initializes Craft Parts features. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix enabling overlays in _enable_craft_parts_features(). Maintainer tigarmo implemented the change, which passed review and testing after a minor environment mix-up was resolved. Successfully merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1249 build(deps): fix overlay migration bug through craft-parts | rockcraft | merged | Merged in commit 55ade214, updating craft-parts to fix overlay migration. It fixes #1217 and shipped in Rockcraft 1.19.1 via release merge #1268. | |
| #322 docs: enable inclusion of overlay document | rockcraft | merged | Merged PR #322 in commit 181c9e1c, enabling inclusion of the Craft Parts overlay document in Rockcraft's documentation. | |
| #367 features: introduce craft-parts features | craft-parts | merged | Merged PR #367 via commit 16a81f95, introducing configurable craft-parts features and an overlay toggle that suppresses overlay action generation when disabled. | |
| #336 features: introduce craft-parts features | craft-parts | merged | Feature controls landed via canonical/craft-parts#367 in commit 16a81f95, adding configurable features and suppression of overlay actions when the overlay feature is disabled. | |
| #299 feat: enable override-overlay | imagecraft | merged | Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support. | |
| #1165 feat: enable override-overlay | rockcraft | merged | Merged in rockcraft#1165 via commit 1024f092, enabling override-overlay, updating a spread test from overlay-script, and documenting the key. | |
| #113 overlay: add overlay support to parts (CRAFT-470) | craft-parts | merged | Merged #113 via commit 2d90e608, adding overlay work-directory definitions, overlay subdirectory properties, and detection of overlay parameters and visibility for CRAFT-470. | |
| #98 Enable overlay feature | imagecraft | closed | Overlay support was implemented in imagecraft PR #110 (commit 00f1348), after craft-parts PR #1035 (b575539e) removed the partition/overlay blocker. |