fix: enable overlays in _enable_craft_parts_features()
Metadata
Current evaluation
Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated.
Suggested action: —
No scores available.
Issue body
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix enabling overlays in _enable_craft_parts_features(). Maintainer tigarmo implemented the change, which passed review and testing after a minor environment mix-up was resolved. Successfully merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that enables overlays in _enable_craft_parts_features(). The change was successfully integrated. Reviewer testing feedback was resolved independently. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #299 feat: enable override-overlay | imagecraft | merged | Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test. | |
| #407 features: reorganize overlay feature tests | craft-parts | merged | Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI. | |
| #110 feat: Support overlay | imagecraft | merged | Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files. | |
| #367 features: introduce craft-parts features | craft-parts | merged | Successfully merged, introducing configurable features for craft-parts including an optional overlay feature to control action generation. Approved by reviewer, passed CI, and integrated after build retrigger. | |
| #336 features: introduce craft-parts features | craft-parts | merged | Merged pull request introducing a configurable feature system to craft-parts, including an initial overlay feature implementation. Approved by reviewer, passed CI, and merged with 620 additions and 12 deletions across 14 files. | |
| #592 fix: delay enabling the overlay feature | rockcraft | merged | Merged fix for #585 that delays overlay feature enablement from module import to Project object creation. Approved by two reviewers, passed CI, and updated six files. | |
| #1249 build(deps): fix overlay migration bug through craft-parts | rockcraft | merged | Resolved overlay migration bug by updating craft-parts. Merged after reviewer approval and passing CI checks. Closes #1217. Diff contains 37 additions and 6 deletions across five files. | |
| #362 feat: add a method to enable craft-parts Features | craft-application | merged | Merged a method for Application subclasses to enable craft-parts features at the correct initialization point, ensuring proper setup order for overlays and logging. Approved, passed CI, and changed 30 lines across two files. |