sources: fix ignore patterns in local sources
Metadata
Current evaluation
Merged backport PR #373 (commit ec0ab362) porting #362 to the 1.18 branch: local sources no longer accumulate a growing, repetitive ignore-pattern list.
Resolution: closed resolved
Reason: PR #373 was merged (2 approvals, 0 unresolved comments) as commit ec0ab362 on the 1.18 branch, cherry-picking #362 (commit 722d8f57) which changed local source ignore handling to stop building a cumulative list of repeated patterns in craft_parts/sources.py.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Don't create a cumulative list of patterns to ignore when processing local sources, or the list can become quite large with repetitions of the same patterns.
This is a backport of #362 to the 1.18 branch.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged backport PR #373 (commit ec0ab362) porting #362 to the 1.18 branch: local sources no longer accumulate a growing, repetitive ignore-pattern list. | |
| stealth/space-bunny-alpha | — | closed resolved | Backport PR #373 (commit ec0ab362) of #362 merged into the 1.18 branch, stopping local sources from accumulating a cumulative, repetitive ignore-pattern list. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged backport PR #373 (commit ec0ab362) of #362 fixed local-source ignore handling by preventing cumulative, repetitive pattern lists on the 1.18 branch. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for local source ignore patterns to prevent cumulative and repetitive lists. This backport of #362 to the 1.18 branch optimizes pattern processing, received approval, and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix preventing cumulative ignore pattern growth in local sources. This change backports PR #362 to the 1.18 branch. |
Update history
No update history recorded yet.
Related work
-
Duplicate Of:
canonical/craft-parts#362
(confidence 97%)
#373 is explicitly described as a backport of #362 to the 1.18 branch; #362 merged as 722d8f57 on main.
-
Likely Fixed By:
canonical/craft-parts#362
(confidence 90%)
Original upstream fix merged first (722d8f57), then backported here.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #362 sources: fix ignore patterns in local sources | craft-parts | merged | Merged as 722d8f57; local sources no longer accumulate repeated ignore patterns. Backported to 1.18 by #373 (ec0ab362). | |
| #363 sources: fix ignore patterns in local sources | craft-parts | merged | Merged PR #363, preventing local-source processing from accumulating repeated ignore patterns; the fix landed as 722d8f57 and was later backported by #373. | |
| #375 Release 1.18.1 | craft-parts | merged | Merged release PR #375 as commit 7d99fbe6, publishing v1.18.1 with the local-source ignore-pattern fix backported by #373. | |
| #369 Release 1.15.3 | craft-parts | merged | Merged as release 1.15.3, backporting the local-source ignore-pattern fix from #362 to the 1.15 maintenance line. | |
| #96 many: fix source ignore patterns (CRAFT-375) | craft-parts | merged | Merged #96 via commit 9fd6ee7c (merge ab69ef78), fixing local-source filtering to exclude generated outputs, support app-defined ignore patterns, and honor custom work directories. | |
| #376 Merge/1.18.1 | craft-parts | merged | PR #376 merged (commit 074d654f) backporting release 1.18.1 to main, including the local-source ignore-pattern fix; hotfix-only pinned linters were intentionally left out. | |
| #425 Release 1.19.2 | craft-parts | merged | Merged release 1.19.2 in #425 (commit 8e3ca2bb), fixing ignored-file exclusion for local sources. |