chore(linter): rebase on starbase linters config
Metadata
Current evaluation
Closed unmerged after review requests; the Starbase Ruff migration was subsequently implemented more narrowly by PR #580 in commit 111c8907.
Resolution: closed superseded
Reason: PR #568 was closed after @tigarmo asked whether it should be dropped, with 11 unresolved review comments. PR #580 later merged the Ruff and Starbase configuration work in commit 111c8907.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes: https://github.com/canonical/craft-parts/issues/562
CRAFT-2098
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after review requests; the Starbase Ruff migration was subsequently implemented more narrowly by PR #580 in commit 111c8907. | |
| stealth/space-bunny-alpha | — | closed superseded | PR to rebase craft-parts linters on Starbase config closed unmerged after tigarmo asked whether to drop it; 11 review comments unresolved. Superseded by merged PR #580 (commit 111c8907) which enabled Ruff, fixing #562. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after @tigarmo asked whether to drop it; its 11 unresolved review comments remained. PR #580 later implemented the Ruff/Starbase change in commit 111c8907. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned and closed after a reviewer asked if it should be dropped. The pull request requested changes with 11 unresolved comments and saw no further activity, so it was not merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Rebasing on starbase linters config was closed and abandoned after a maintainer suggested dropping it. The changes were not merged. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-parts#580
(confidence 99%)
Merged commit 111c8907 enabled Ruff using the Starbase configuration.
-
Likely Fixed By:
canonical/craft-parts#562
(confidence 98%)
The issue targeted by #568 was resolved by the Ruff migration in #580.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #574 chore(linter): rebase on starbase linters config | craft-parts | closed | Closed unmerged for redo; the narrower Starbase Ruff migration landed in #580 (111c8907), with autofixes in #581 (30b73d97). | |
| #2896 chore: fix ruff, mypy, and pyright findings ahead of Starbase merge | charmcraft | closed | PR #2896 was closed unmerged with no replacement; lint and OSV checks remained failing and review was still pending. | |
| #728 chore: switch to starbase | craft-providers | closed | Closed unmerged after review remained pending; the Starbase migration was later completed by #786/#787, with #787 merged as commit 808597b. | |
| #588 chore: use the latest ruff config from starbase | craft-application | merged | Merged PR #588 as commit 44b1a940, adopting starbase's latest Ruff configuration and updating linting across 86 files for the Starflow migration. | |
| #237 chore(merge): update starbase (2026-07-14) | craft-archives | closed | PR #237 was closed unmerged after failing CI checks and leaving 29 review comments unresolved; no resolving commit was identified. | |
| #22 chore(lint): update ruff and config | starbase | merged | Merged in canonical/starbase#22 via commit f3d35a6, updating Ruff and its config to ignore excessive test-function arguments (PLR0913). | |
| #113 chore: merge the latest starbase | craft-archives | closed | Chore PR to merge latest Starbase into craft-archives. Closed unmerged with no review or CI; the Starbase sync was completed later by merged PR #163 (commit 0872a9c). | |
| #580 chore(linter): enable ruff base on starbase config | craft-parts | merged | Merged in #580 via commit 111c8907, enabling Ruff based on the Starbase configuration. | |
| #103 chore: fix new lints from ruff 0.12 | craft-grammar | merged | Merged PR #103 as a3ef1dd, updating Ruff to 0.12 and fixing resulting lint errors across four files; cherry-picked from canonical/starbase#409. | |
| #787 chore: rebase onto starbase | craft-providers | merged | Merged PR #787 as commit 808597b, rebasing craft-providers onto Starbase while reconciling documentation, tests, the uv lockfile, and the docs workflow. |