chore(linter): rebase on starbase linters config
Metadata
Current evaluation
Closed unmerged for redo; the narrower Starbase Ruff migration landed in #580 (111c8907), with autofixes in #581 (30b73d97).
Resolution: closed superseded
Reason: A maintainer closed the unfinished PR after deciding to redo the work. The replacement rollout was split into merged PR #580, which enabled Ruff from Starbase configuration, and PR #581, which applied the resulting autofixes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Drop isort and pylint
Ignore current pathlib.Path checks
Bump Python version to 3.10
Updated linters to
pyright -> 1.1.333
ruff -> 0.1.3
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged for redo; the narrower Starbase Ruff migration landed in #580 (111c8907), with autofixes in #581 (30b73d97). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged pending a redo; the linter migration was reworked into merged PRs #580 (111c8907) and #581 (30b73d97) to enable Ruff and apply autofixes. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged pending a redo; the narrower Starbase-based Ruff rollout was reworked and merged in #580 and #581. | |
| stealth/space-bunny-alpha | — | closed superseded | PR #574 was closed unmerged after pydantic compatibility problems and unresolved reviews; the linter migration was redone and merged in #580 and #581. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to pydantic compatibility issues and unresolved review comments. The linter configuration update and Python bump were abandoned pending a complete redo following external discussion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. The linter configuration update and Python version bump were abandoned following reviewer feedback on commit history and pydantic compatibility. The team plans to redo the changes externally. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-parts#580
(confidence 99%)
Merged as 111c8907 and replaced #574's broad approach with a narrower Starbase-based Ruff configuration.
-
Related To:
canonical/craft-parts#581
(confidence 98%)
Merged as 30b73d97 and applied the autofixes resulting from #580.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #568 chore(linter): rebase on starbase linters config | craft-parts | closed | Closed unmerged after review requests; the Starbase Ruff migration was subsequently implemented more narrowly by PR #580 in commit 111c8907. | |
| #588 chore: use the latest ruff config from starbase | craft-application | merged | Merged PR #588 as commit 44b1a940, adopting starbase's latest Ruff configuration and updating linting across 86 files for the Starflow migration. | |
| #2896 chore: fix ruff, mypy, and pyright findings ahead of Starbase merge | charmcraft | closed | PR #2896 was closed unmerged with no replacement; lint and OSV checks remained failing and review was still pending. | |
| #581 chore(linter): ruff auto fix base on starbase config | craft-parts | merged | Merged Ruff autofixes across 156 files to align craft-parts with Starbase's lint configuration; change landed as commit 30b73d97. | |
| #103 chore: fix new lints from ruff 0.12 | craft-grammar | merged | Merged PR #103 as a3ef1dd, updating Ruff to 0.12 and fixing resulting lint errors across four files; cherry-picked from canonical/starbase#409. | |
| #728 chore: switch to starbase | craft-providers | closed | Closed unmerged after review remained pending; the Starbase migration was later completed by #786/#787, with #787 merged as commit 808597b. | |
| #22 chore(lint): update ruff and config | starbase | merged | Merged in canonical/starbase#22 via commit f3d35a6, updating Ruff and its config to ignore excessive test-function arguments (PLR0913). | |
| #787 chore: rebase onto starbase | craft-providers | merged | Merged PR #787 as commit 808597b, rebasing craft-providers onto Starbase while reconciling documentation, tests, the uv lockfile, and the docs workflow. | |
| #219 chore(merge): update starbase (2026-10-13) | craft-grammar | closed | Merged routine starbase sync updating CI workflows, lint configs, and docs tooling to align with starbase/main. | |
| #580 chore(linter): enable ruff base on starbase config | craft-parts | merged | Merged in #580 via commit 111c8907, enabling Ruff based on the Starbase configuration. |