← Back to issue list

chore(linter): rebase on starbase linters config

View original Github issue

Metadata

Project
craft-parts
Number
#574
Type
pull request
State
closed
Author
syu-w
Labels
Created
Updated
Closed

Current evaluation

Closed without merging due to pydantic compatibility issues and unresolved review comments. The linter configuration update and Python bump were abandoned pending a complete redo following external discussion.

Suggested action:

No scores available.

Issue body

Drop isort and pylint Ignore current pathlib.Path checks Bump Python version to 3.10 Updated linters to pyright -> 1.1.333 ruff -> 0.1.3

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merging due to pydantic compatibility issues and unresolved review comments. The linter configuration update and Python bump were abandoned pending a complete redo following external discussion.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. The linter configuration update and Python version bump were abandoned following reviewer feedback on commit history and pydantic compatibility. The team plans to redo the changes externally.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#568 chore(linter): rebase on starbase linters config craft-parts closed Abandoned and closed after a reviewer asked if it should be dropped. The pull request requested changes with 11 unresolved comments and saw no further activity, so it was not merged.
86%
#112 chore(deps): update to pydantic 2 & bump-pydantic craft-archives closed The dependency update to Pydantic 2 was closed without merging. Lacking reviewer feedback, CI validation, and sustained activity, the pull request was abandoned.
76%
#1807 chore: merge main to pydantic feature branch charmcraft closed Closed without merging. The pydantic feature branch synchronization received no reviews or CI checks and was abandoned after 706 days.
75%
#439 chore(linter): misc fix rockcraft merged Merged linter chore PR fixing miscellaneous issues and an unexpected pyright error from a rebase onto main. Approved by two reviewers, changes span 16 files with 86 additions and 76 deletions.
74%
#237 chore(merge): update starbase (2026-07-14) craft-archives closed Closed without merging. The maintainer abandoned the starbase sync and CI update after an AI-generated branch failed to follow instructions, leaving multiple CI checks failing and unresolved review comments.
73%
#181 chore: Rebase on starbase imagecraft merged Merged after rebasing on starbase. Initial CI and test failures were resolved via workarounds and a follow-up PR. Approved by two reviewers and successfully passed checks prior to merge.
72%
#28 chore(deps): update dependency pydantic to v2 - autoclosed craft-grammar closed Renovate autoclosed this pydantic v2 dependency update without merging. The pull request received no reviews or CI checks and was automatically closed, indicating it was superseded or abandoned.
72%
#236 chore(merge): update starbase (2026-07-14) craft-archives closed Closed without merging due to a failing OSV-scanner check and 52 unresolved review comments. The routine maintenance PR intended to sync build conventions from starbase/main was abandoned.
72%
#114 chore(deps): update dependency lint/pylint to v3 craft-store closed Closed without merging. The dependency update was abandoned after maintainers confirmed the project is removing pylint entirely.
72%
#238 chore(lint): get around pydantic 2.10.x bugs craft-store merged Merged a workaround for pydantic 2.10.x bugs causing silent errors and Url comparison failures. Resolves compatibility issues in pydantic 2.10 and pydantic_core, approved by reviewers, and passed all CI checks.
71%