← Back to issue list

rust_plugin: multiple fixes (#560)

View original Github issue

Metadata

Project
craft-parts
Number
#570
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged as #560. The rust_plugin was updated to remove compiler plugins from final Snap packages and eliminate a redundant channel override causing type-checking errors. Approved by one reviewer and passed CI checks.

Suggested action:

No scores available.

Issue body

* Detect and remove compiler plugins from the final Snap package * Remove the redundant channel override that caused some issues with type-checking, and it is actually not needed. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged as #560. The rust_plugin was updated to remove compiler plugins from final Snap packages and eliminate a redundant channel override causing type-checking errors. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged #560 by cmatsuoka. The update detects and removes compiler plugins from the final Snap package and eliminates a redundant channel override that caused type-checking issues.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#560 rust_plugin: multiple fixes craft-parts merged Merged Rust plugin fixes resolving issue #559. Changes remove unnecessary rust_channel override typing checks and improve compiler plugin identification and removal. Approved by reviewers and merged despite an unrelated CI pylint failure.
88%
#2538 rust plugin: fix usage of rust-channel snapcraft merged Merged PR #2538 fixes the Rust plugin by replacing the deprecated rustup.sh channel argument with rustup toolchain setup. Approved, passed CI, and merged to master.
74%
#198 plugins: rust craft-parts merged Merged the rust plugin port from snapcraft to craft-parts. Approved by a reviewer, passed CI, and landed after related PR #199. Addresses CRAFT-955.
73%
#2434 rust plugin: refactor to use the latest rustup snapcraft merged Merged Rust plugin refactor for latest rustup. Removed deprecated flags, added command qualifiers, established shared rustup/cargo directory, and standardized config. Approved and passed CI.
73%
#2431 rust plugin: update to use latest rustup command options snapcraft merged Merged update to the Rust plugin replacing deprecated rustup command options with current equivalents. Approved by a reviewer, passed CI, modified five files, and maintained 94.5% test coverage.
73%
#2170 rust plugin: fix cargo builds and run tests snapcraft merged Merged fixes for cargo builds in the Rust plugin along with new tests. The change updated two files with 41 additions and 10 deletions, achieving 100% diff coverage.
71%
#2158 rust plugin: fix cargo builds and run tests snapcraft closed Changes to fix cargo builds and add tests to the Rust plugin were closed and superseded by PR #2170 after the author discovered cargo test conflicts with cross-compilation, requiring a rework.
71%
#530 plugins/rust_plugin: rewrite the plugin to improve UX craft-parts merged Merged a Rust plugin rewrite improving UX with default Rustup, LTO, toolchain version, and feature toggles. Failing tests for Ubuntu 20.04 Chisel support were resolved via a separate PR and rebasing prior to merge.
71%
#2693 rust plugin: support for s390x snapcraft merged Added s390x architecture support to the Rust plugin and merged. Approved by reviewer, passed CI checks, and modified three files with minimal changes. Coverage increased slightly.
71%
#903 fix(rust_plugin): fix dependency validation logic craft-parts merged Merged fix for Rust dependency validation mishandling rustup exit codes. Updates logic to expect exit code 1 instead of 127 without a default toolchain, adds two tests, and resolves #890. Approved and merged directly without rebasing.
70%