← Back to issue list

rust_plugin: multiple fixes (#560)

View original Github issue

Metadata

Project
craft-parts
Number
#570
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged backport #570 (8d87e98e) of #560: the Rust plugin now removes compiler plugins from final Snaps and drops a redundant channel override.

Resolution: closed resolved

Reason: PR #570 was merged with commit 8d87e98e, backporting the fixes from canonical PR #560 (fbefe6b8). The changes resolve plugin leakage and redundant rust-channel type-checking behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

* Detect and remove compiler plugins from the final Snap package * Remove the redundant channel override that caused some issues with type-checking, and it is actually not needed. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged backport #570 (8d87e98e) of #560: the Rust plugin now removes compiler plugins from final Snaps and drops a redundant channel override.
stealth/space-bunny-alpha — closed resolved Merged Rust plugin fixes in canonical/craft-parts#560 (fbefe6b8), removing compiler plugins from final Snaps and a redundant channel override; backported in #570 (8d87e98e).
qwen/qwen3.6-35b-a3b — — Merged as #560. The rust_plugin was updated to remove compiler plugins from final Snap packages and eliminate a redundant channel override causing type-checking errors. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged #560 by cmatsuoka. The update detects and removes compiler plugins from the final Snap package and eliminates a redundant channel override that caused type-checking issues.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#560 (confidence 100%)

    Original merged PR containing the Rust plugin fixes backported by #570.

  • Related To: craft-parts#559 (confidence 98%)

    Rust dependency-validation issue fixed by the original PR #560.

Related issues

Issue Project State Summary Similarity
#560 rust_plugin: multiple fixes craft-parts merged Merged rust_plugin fixes: removed typing checks around the rust_channel override and added detection/removal of installed compiler plugins via the .data.rel.ro symbol. Squash-merged as fbefe6b8; fixes #559.
85%
#2158 rust plugin: fix cargo builds and run tests snapcraft closed PR closed as superseded: the rust-plugin-improvements branch was deleted and the work was reworked and merged as snapcore/snapcraft#2170 (commit 4f80a1051) after cargo test broke cross-compilation.
74%
#579 Add new plugin: rust snapcraft merged Merged PR #579 as commit 24f1def33, adding Snapcraft's Rust plugin, resolving conflicts, and updating plugin-list test expectations.
74%
#2169 Rust plugin improvements snapcraft closed Closed unmerged and superseded by snapcraft#2170, merged as commit 4f80a1051 to fix Cargo builds and add Rust plugin tests.
72%
#894 fix(plugins/rust): fix snap dependency handling craft-parts closed PR #894 was superseded by #903, merged as dc79714c, correcting Rust plugin dependency validation and rustup installation behavior.
71%
#2580 rust plugin: fix linker on i386 snapcraft merged Merged PR #2580 in commit 261ec5978, fixing Rust plugin i386 builds to use the available i686-linux-gnu-gcc linker.
70%
#2170 rust plugin: fix cargo builds and run tests snapcraft merged Merged as commit 4f80a1051, fixing Rust plugin Cargo builds, skipping tests during cross-compilation, and adding tests.
70%