← Back to issue list

Rust plugin improvements

View original Github issue

Metadata

Project
snapcraft
Number
#2169
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged and superseded by snapcraft#2170, merged as commit 4f80a1051 to fix Cargo builds and add Rust plugin tests.

Resolution: closed superseded

Reason: PR #2169 was closed without merging or an explanation. The immediately following Rust plugin PR, snapcraft#2170, merged as 4f80a1051 and delivered the Cargo build fixes and tests, indicating it replaced this proposal.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by snapcraft#2170, merged as commit 4f80a1051 to fix Cargo builds and add Rust plugin tests.
stealth/space-bunny-alpha — closed stale Rust plugin improvements was closed unmerged, with no recorded explanation, reviewers, CI checks, or linked resolution.
qwen/qwen3.6-35b-a3b — — Rust plugin improvements was closed without merging. With no reviewer activity, CI checks, or comments, the changes were not integrated and the request appears abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging, comments, or checks. Missing required contribution guidelines and test results. Likely abandoned or closed as stale due to zero activity since submission. No code changes were integrated.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#2170 (confidence 90%)

    Merged follow-up with the Rust plugin Cargo build fixes and tests.

Related issues

Issue Project State Summary Similarity
#2158 rust plugin: fix cargo builds and run tests snapcraft closed PR closed as superseded: the rust-plugin-improvements branch was deleted and the work was reworked and merged as snapcore/snapcraft#2170 (commit 4f80a1051) after cargo test broke cross-compilation.
82%
#579 Add new plugin: rust snapcraft merged Merged PR #579 as commit 24f1def33, adding Snapcraft's Rust plugin, resolving conflicts, and updating plugin-list test expectations.
81%
#2170 rust plugin: fix cargo builds and run tests snapcraft merged Merged as commit 4f80a1051, fixing Rust plugin Cargo builds, skipping tests during cross-compilation, and adding tests.
78%
#198 plugins: rust craft-parts merged Merged PR #198 (bb92a132) ported Snapcraft’s Rust plugin into craft-parts for CRAFT-955 after prerequisite test refactor #199.
76%
#1606812 Add plugin rust snapcraft (launchpad) closed Rust plugin request implemented: snapcore/snapcraft#579 by ~sergiusens merged as commit 24f1def33, adding the Rust plugin. Launchpad ticket #1606812 closed once the plugin landed.
75%
#570 rust_plugin: multiple fixes (#560) craft-parts merged Merged backport #570 (8d87e98e) of #560: the Rust plugin now removes compiler plugins from final Snaps and drops a redundant channel override.
72%
#1838 tests: fix broken rust test snap snapcraft merged Merged in snapcraft#1838 as 0fe7def33, removing an unnecessary unversioned log dependency that broke the rust-with-revisions test snap.
72%
#1562 Record rust versions snapcraft merged Merged as commit 1ddc34f19, updating the Rust plugin to record rustup, rustc, and Cargo versions; this completed the versioning portion of #1475.
71%
#894 fix(plugins/rust): fix snap dependency handling craft-parts closed PR #894 was superseded by #903, merged as dc79714c, correcting Rust plugin dependency validation and rustup installation behavior.
70%