← Back to issue list

[EXPERIMENTAL] build(deps): use pydantic 2

View original Github issue

Metadata

Project
craft-parts
Number
#582
Type
pull request
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in Aug 2024 by @lengau as superseded; the Pydantic 2 migration landed later via merged PR #771 (commit 6b155294) plus follow-ups #776, #778, #794, #811.

Resolution: closed superseded

Reason: @lengau closed the experimental branch with the comment "Closing as superseded" (2024-08-19). The same migration was completed later by merged PR #771 "chore!: lift-and-shift update to pydantic 2" at commit 6b155294, followed by #776, #778, #794 and #811.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in Aug 2024 by @lengau as superseded; the Pydantic 2 migration landed later via merged PR #771 (commit 6b155294) plus follow-ups #776, #778, #794, #811.
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded; the Pydantic 2 migration later landed via canonical/craft-parts#771, commit 6b155294.
stealth/space-bunny-alpha — closed superseded Pydantic 2 migration PR #582 was closed unmerged as superseded; craft-parts completed the migration in merged PR #771 (6b155294), followed by cleanup #778.
qwen/qwen3.6-35b-a3b — — Dependency update to pydantic 2 was closed as superseded by @lengau. No reviews or CI checks were completed prior to closure.
qwen3.6-35b-a3b-mtp-q6 — — Proposed pydantic 2 dependency update was closed as superseded by maintainer lengau. The migration was completed through an alternative PR.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/craft-parts#771 (confidence 95%)

    Merged lift-and-shift Pydantic 2 migration, commit 6b155294, across 38 files; this PR's change was never merged.

  • Related To: canonical/craft-parts#776 (confidence 70%)

    Follow-up 'feat: add pydantic models for all sources' (3d880869), phase 1 of the Pydantic 2 model work.

  • Related To: canonical/craft-parts#778 (confidence 65%)

    Follow-up 'chore: pydantic 2 related cleanup' (68d61fa0) completing the migration follow-ups.

  • Related To: canonical/craft-parts#811 (confidence 55%)

    Follow-up dropping unnecessary pydantic-yaml now that Pydantic 2 is in use (1debce16).

Related issues

Issue Project State Summary Similarity
#1999 build(deps): update pydantic etc. (main) charmcraft closed Renovate PR #1999 proposed Pydantic 2.10.2 and pydantic-core 2.27.1, but was closed unmerged after 664 days of inactivity; neither version landed.
77%
#1778 Work/1768/pydantic 2 charmcraft closed Closed unmerged as an exploratory branch; the Pydantic 2 migration landed via #1777 (70078b03), followed by main-branch integration in #1817 (394e6e55).
74%
#601 feat: upgrade to pydantic 2.x craft-parts closed Closed unmerged as superseded after ~8 months stalled with 39 unresolved review comments. Pydantic 2 upgrade was later delivered by canonical/craft-parts#771 (commit 6b155294) plus #776, #778, #794.
74%
#173 feat: upgrade to pydantic 2.x craft-application closed Closed unmerged after the Pydantic 2 migration landed via craft-application#401 (c2f0978a); maintainer lengau credited #173 as helpful during that migration.
74%
#2314 build(deps): update dependency pydantic to ~=2.11,<2.12 (main) - autoclosed charmcraft closed Renovate PR #2314 was autoclosed unmerged after 471 days; the Pydantic 2.11 update was not shipped, with snap-build, snap tests, and diff-schema failing.
74%
#483 upgrade to pydantic 2.x craft-providers closed PR #483 (a one-line pyproject.toml bump to pydantic>=2) was closed unmerged by its author as a duplicate; maintainers pointed to craft-providers#451, which landed as commit f380a9e and set pydantic~=2.4.
73%
#2155 build(deps): update dependency pydantic to v2.10.6 (main) charmcraft closed Pydantic 2.10.6 update closed unmerged; a later toolchain and Pydantic update merged in canonical/charmcraft#2310 via commit e635550d.
72%
#48 build(deps): bump pydantic from 1.8.1 to 1.8.2 craft-providers closed Superseded by merged PR canonical/craft-providers#49, which re-froze requirements and upgraded pydantic from 1.8.1 to 1.8.2.
72%
#451 build(deps): bump pydantic to v2 craft-providers merged Merged PR #451 upgraded craft-providers to Pydantic v2 for 2.0; current project metadata requires pydantic~=2.4.
72%
#1833 build(deps): update dependency pydantic-core to v2.23.0 (main) charmcraft closed Closed unmerged after maintainers deferred the core-only bump to a future Pydantic update; the broader dependency update later merged in #2310 as e635550d.
71%