← Back to issue list

upgrade to pydantic 2.x

View original Github issue

Metadata

Project
craft-providers
Number
#483
Type
pull request
State
closed
Author
linostar
Labels
—
Created
Updated
Closed

Current evaluation

PR #483 (a one-line pyproject.toml bump to pydantic>=2) was closed unmerged by its author as a duplicate; maintainers pointed to craft-providers#451, which landed as commit f380a9e and set pydantic~=2.4.

Resolution: closed superseded

Reason: A maintainer comment on 2023-12-14 stated a pydantic 2 PR (#451) was already queued for a coordinated craft-wide upgrade, and author linostar closed #483 as a duplicate the same day. #451 later merged as commit f380a9e ('build(deps): bump pydantic to v2'), with pyproject.toml now requiring pydantic~=2.4.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Upgrading pyproject.toml to require pydantic>=2

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #483 (a one-line pyproject.toml bump to pydantic>=2) was closed unmerged by its author as a duplicate; maintainers pointed to craft-providers#451, which landed as commit f380a9e and set pydantic~=2.4.
qwen/qwen3.6-35b-a3b — closed superseded Closed as duplicate; superseded by #451, which handles the pydantic 2.x upgrade across all craft-* repos.

Update history

Date Change
created

Related work

  • Superseded By: canonical/craft-providers#451 (confidence 98%)

    Mainter-cited duplicate/superseding PR; merged as commit f380a9e and the actual pydantic 2.x upgrade for craft-providers.

  • Related To: canonical/craft-archives#103 (confidence 60%)

    Sibling pydantic 2.x bump by the same author, cited in the closing comment; merged as b69f44a.

  • Related To: canonical/craft-parts#601 (confidence 60%)

    Sibling pydantic 2.x bump by the same author, cited in the closing comment; closed unmerged and later replaced by craft-parts#771.

Related issues

Issue Project State Summary Similarity
#451 build(deps): bump pydantic to v2 craft-providers merged Merged PR #451 upgraded craft-providers to Pydantic v2 for 2.0; current project metadata requires pydantic~=2.4.
80%
#173 feat: upgrade to pydantic 2.x craft-application closed Closed unmerged after the Pydantic 2 migration landed via craft-application#401 (c2f0978a); maintainer lengau credited #173 as helpful during that migration.
80%
#601 feat: upgrade to pydantic 2.x craft-parts closed Closed unmerged as superseded after ~8 months stalled with 39 unresolved review comments. Pydantic 2 upgrade was later delivered by canonical/craft-parts#771 (commit 6b155294) plus #776, #778, #794.
80%
#1999 build(deps): update pydantic etc. (main) charmcraft closed Renovate PR #1999 proposed Pydantic 2.10.2 and pydantic-core 2.27.1, but was closed unmerged after 664 days of inactivity; neither version landed.
77%
#48 build(deps): bump pydantic from 1.8.1 to 1.8.2 craft-providers closed Superseded by merged PR canonical/craft-providers#49, which re-froze requirements and upgraded pydantic from 1.8.1 to 1.8.2.
76%
#370 chore(deps): update dependency pydantic to v2 craft-providers closed Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0.
76%
#1351 chore(deps): update dependency pydantic to v2 charmcraft closed Renovate PR bumping pydantic 1.10.13 -> 2.4.2 was closed unmerged by lengau ("will need its own project"). The upgrade later landed via PR #1777 (70078b03), merged to main in #1817 (394e6e55).
75%
#103 feat: upgrade to pydantic 2.x craft-archives merged Merged PR #103 as commit b69f44a, upgrading craft-archives to Pydantic 2.x after three approvals; residual review feedback was moved to #118.
75%
#401 build!: update to pydantic 2 craft-application merged Merged PR #401 as commit c2f0978a, migrating craft-application to Pydantic 2 across 23 files; craft-grammar#34 was required for the tests.
75%
#2314 build(deps): update dependency pydantic to ~=2.11,<2.12 (main) - autoclosed charmcraft closed Renovate PR #2314 was autoclosed unmerged after 471 days; the Pydantic 2.11 update was not shipped, with snap-build, snap tests, and diff-schema failing.
74%