feat: upgrade to pydantic 2.x
Metadata
Current evaluation
Closed unmerged as superseded after ~8 months stalled with 39 unresolved review comments. Pydantic 2 upgrade was later delivered by canonical/craft-parts#771 (commit 6b155294) plus #776, #778, #794.
Resolution: closed superseded
Reason: Maintainer lengau closed the PR on 2024-08-19 with the comment "Closing as superseded :-)". It never merged; the migration landed instead via canonical/craft-parts#771, merged as commit 6b155294 ("chore!: lift-and-shift update to pydantic 2"), followed by #776, #778 and #794.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as superseded after ~8 months stalled with 39 unresolved review comments. Pydantic 2 upgrade was later delivered by canonical/craft-parts#771 (commit 6b155294) plus #776, #778, #794. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as superseded; the Pydantic 2 migration was subsequently delivered by canonical/craft-parts#771 in commit 6b155294. | |
| qwen/qwen3.6-35b-a3b | — | — | The pydantic 2.x upgrade for craft-parts was closed as superseded after addressing review feedback on validation error reporting. The changes were replaced by a newer update. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Upgrading craft-parts to Pydantic 2.x was closed as superseded. The author addressed a validation error reporting regression using Annotated, but the changes were ultimately replaced by a separate update. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-parts#771
(confidence 97%)
Merged PR delivering the Pydantic 2 migration as commit 6b155294 across 38 files, replacing this PR.
-
Related To:
canonical/craft-parts#776
(confidence 80%)
Follow-up 'feat: add pydantic models for all sources' (commit 3d880869), part of the same multi-PR Pydantic 2 effort.
-
Related To:
canonical/craft-parts#778
(confidence 78%)
Follow-up 'chore: pydantic 2 related cleanup' (commit 68d61fa0), completing the migration after #771.
-
Related To:
canonical/craft-parts#794
(confidence 72%)
Follow-up 'chore: remove pydantic warnings' (commit 5c1c7dd3), post-migration tidy-up.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #173 feat: upgrade to pydantic 2.x | craft-application | closed | Closed unmerged after the Pydantic 2 migration landed via craft-application#401 (c2f0978a); maintainer lengau credited #173 as helpful during that migration. | |
| #103 feat: upgrade to pydantic 2.x | craft-archives | merged | Merged PR #103 as commit b69f44a, upgrading craft-archives to Pydantic 2.x after three approvals; residual review feedback was moved to #118. | |
| #483 upgrade to pydantic 2.x | craft-providers | closed | PR #483 (a one-line pyproject.toml bump to pydantic>=2) was closed unmerged by its author as a duplicate; maintainers pointed to craft-providers#451, which landed as commit f380a9e and set pydantic~=2.4. | |
| #48 build(deps): bump pydantic from 1.8.1 to 1.8.2 | craft-providers | closed | Superseded by merged PR canonical/craft-providers#49, which re-froze requirements and upgraded pydantic from 1.8.1 to 1.8.2. | |
| #1999 build(deps): update pydantic etc. (main) | charmcraft | closed | Renovate PR #1999 proposed Pydantic 2.10.2 and pydantic-core 2.27.1, but was closed unmerged after 664 days of inactivity; neither version landed. | |
| #582 [EXPERIMENTAL] build(deps): use pydantic 2 | craft-parts | closed | Closed unmerged in Aug 2024 by @lengau as superseded; the Pydantic 2 migration landed later via merged PR #771 (commit 6b155294) plus follow-ups #776, #778, #794, #811. | |
| #728 Migrate to Pydantic 2.x | craft-parts | closed | Pydantic 2 migration landed in canonical/craft-parts#771 via commit 6b155294, followed by cleanup in #778; craft-parts now requires pydantic>=2.0.0. | |
| #401 build!: update to pydantic 2 | craft-application | merged | Merged PR #401 as commit c2f0978a, migrating craft-application to Pydantic 2 across 23 files; craft-grammar#34 was required for the tests. | |
| #370 chore(deps): update dependency pydantic to v2 | craft-providers | closed | Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0. | |
| #765 Update dependencies, specially unpinning pydantic now that craft-parts is up to it | charmcraft | merged | Merged into main as 45e0e48c (change c3b28ffa), updating dependencies and unpinning pydantic after craft-parts compatibility was released in 1.1.2. |