fix: stage and prime content in all partitions by default
Metadata
Current evaluation
PR #663 (fix: stage and prime content in all partitions by default) was closed unmerged in favour of #664; the final fix landed via merged PR #668, commit 85b9ba7a, implementing it in the fileset parser instead of PartSpec validators.
Resolution: closed superseded
Reason: Maintainer mr-cal commented "Closing in favor of #664" on 2024-02-20; #664 was itself closed unmerged and the behaviour was implemented and merged in PR #668 as commit 85b9ba7a, which closed issue #650.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
When partitions are enabled, all content will be staged and primed in all partitions by "default".
I put "default" in quotes because I'm not setting the default in the [PartSpec pydantic model](https://github.com/canonical/craft-parts/blob/c11570597d4a397aba1744fa08adcd344682246e/craft_parts/parts.py#L59). I can't set the default value outright, but I can modify the data with a `@validator` function. I would probably validate the usage of partitions inside the `PartSpec` model as well.
As a final confusing note, I think @lengau and I both implemented the same validation in different ways: [here](https://github.com/canonical/craft-parts/blob/c11570597d4a397aba1744fa08adcd344682246e/craft_parts/lifecycle_manager.py#L158) and [here](https://github.com/canonical/craft-parts/blob/c11570597d4a397aba1744fa08adcd344682246e/craft_parts/lifecycle_manager.py#L162).
Fixes #650
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #663 (fix: stage and prime content in all partitions by default) was closed unmerged in favour of #664; the final fix landed via merged PR #668, commit 85b9ba7a, implementing it in the fileset parser instead of PartSpec validators. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as superseded by canonical/craft-parts#664; the final fix merged via #668 in commit 85b9ba7a, changing fileset parsing to stage and prime all partitions by default. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by PR #664. The pull request was closed without merging, as the maintainer redirected the partition staging and priming implementation to a follow-up PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by PR #664. The pull request aimed to fix #650 by staging and priming content in all partitions by default via a Pydantic validator. Closed by the maintainer without merging. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-parts#664
(confidence 95%)
Author's own closing comment names #664 as the replacement PR
-
Related To:
canonical/craft-parts#650
(confidence 95%)
#663 states "Fixes #650"; that issue is closed by the merged #668
-
Superseded By:
canonical/craft-parts#668
(confidence 90%)
Merged commit 85b9ba7a delivering the fix in the fileset parser, closing #650
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #664 fix: stage and prime content in all partitions by default | craft-parts | closed | Closed unmerged in favor of an alternative; PR #668 implemented default all-partition staging and priming and merged as commit 85b9ba7a. | |
| #668 fix: stage and prime content in all partitions by default | craft-parts | merged | Merged in #668 as 85b9ba7a: filesets now stage and prime across all partitions by default and reject ambiguous configurations, fixing #650. | |
| #1123 fix: Prime content from overlay when split into partitions | craft-parts | merged | Merged PR #1123 (commit 3540e306), fixing overlay priming with partitions by using stage content and migration state while preserving existing prime state files. | |
| #607 fix(partitions): use base prime dir for getting primed stage packages | craft-parts | closed | Closed unmerged and superseded by the namespaced-partition work merged in #627 via commit 9fe38d11. | |
| #834 fix: use partitions for stage-packages tracking | craft-parts | merged | Merged PR #834 as 4cbc6006, making stage-package tracking search primed files across partitions and fixing #804 for common cases; duplicate files across partitions remain unsupported. | |
| #650 Include all partitions by default for `stage` and `prime` keywords | craft-parts | closed | Fixed by merged PR #668 (commit 85b9ba7a): stage and prime now include all partitions by default while retaining per-partition filters. |