fix: stage and prime content in all partitions by default
Metadata
Current evaluation
Closed in favor of a different solution. The partition validator redesign and default stage/prime content logic was superseded by an alternative implementation.
Suggested action: —
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
### chore: redesign partition validators
This commit combines two redundant validators and changes where partition usage in parts is validated.
Originally, I added a [validator](https://github.com/canonical/craft-parts/pull/493/files#diff-68d2086e111409ee4298829260c916b031d71f8b27081f83b135ce59d5ff8a66R152) when the `LifecycleManager` was initialized. Then Alex added [another](https://github.com/canonical/craft-parts/pull/517/files#diff-68d2086e111409ee4298829260c916b031d71f8b27081f83b135ce59d5ff8a66R159) (and better) validator also during `LifecycleManager` initialization based on this [prototype](https://github.com/canonical/craft-parts/commit/075eac2b04b70f97388faeee74a5679fa2c8c92c#diff-68d2086e111409ee4298829260c916b031d71f8b27081f83b135ce59d5ff8a66R393).
But things have changed. Now the `partitions` are provided to a part, so validation can occur when the part is initialized. This paves the way for the next commit.
### fix: stage and prime content in all partitions by default
This is similar to #663, but the processing occurs when the part is initialized and after the filter keywords are validated. It also uses a more complex data structure that later gets flattened out.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed in favor of a different solution. The partition validator redesign and default stage/prime content logic was superseded by an alternative implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by an alternative approach. The PR refactored partition validators and proposed staging and priming content across all partitions by default. After positive review, the author closed it to pursue a different solution. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #663 fix: stage and prime content in all partitions by default | craft-parts | closed | Superseded by PR #664. The pull request was closed without merging, as the maintainer redirected the partition staging and priming implementation to a follow-up PR. | |
| #668 fix: stage and prime content in all partitions by default | craft-parts | merged | Merged after resolving issue #650 by modifying the fileset parser to stage and prime content across all partitions by default, instead of altering keyword defaults. Ambiguous partition configurations are now rejected. Merged following dependency #669. | |
| #1123 fix: Prime content from overlay when split into partitions | craft-parts | merged | Merged fix for priming overlay content when split into partitions. Replaces direct overlay reliance with stage directory and migration state. Approved by three reviewers, passed all CI checks, and resolves issue #1127. |