fix: use partitions for stage-packages tracking
Metadata
Current evaluation
Merged to fix issue #804. The change updates stage-package tracking to scan primed files per partition, resolving failures in common partitioned setups. Multi-partition tracking still requires deeper refactoring. Approved by three reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
This localized fix addresses the issue of stage-package tracking failing in
the presence of partitions by looking for the primed files in each partition.
This solves the most common cases but doesn't fix the issue where a given file
might be present in multiple partitions, as this needs a deeper refactoring of
the state tracking (see discussion in https://github.com/canonical/craft-parts/issues/804).
Fixes https://github.com/canonical/craft-parts/issues/804
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix issue #804. The change updates stage-package tracking to scan primed files per partition, resolving failures in common partitioned setups. Multi-partition tracking still requires deeper refactoring. Approved by three reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a localized fix resolving stage-package tracking failures with partitions by scanning primed files per partition. Addresses issue #804 for common cases, though full resolution requires deeper state tracking refactoring. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #662 feat(executor): check for stage file collisions in each partition | craft-parts | merged | Merged. Adds stage file collision checks per partition to fix issue #633. Includes refactored unit tests and new integration tests. Approved by reviewers and passed CI. | |
| #668 fix: stage and prime content in all partitions by default | craft-parts | merged | Merged after resolving issue #650 by modifying the fileset parser to stage and prime content across all partitions by default, instead of altering keyword defaults. Ambiguous partition configurations are now rejected. Merged following dependency #669. | |
| #804 Stage package tracking is unaware of partitions | craft-parts | closed | Closed. Proposed a short-term fix to track stage packages per-partition during priming, with a long-term partition-aware solution planned. A temporary workaround branch was created to disable tracking. | |
| #652 feat(partitions): clean partition directories | craft-parts | merged | Merged changes cleaning partition directories when the partitions feature is enabled. Approved by two reviewers, passed CI, and resolves issue #634. | |
| #1164 feat: symlinks for aliased partition to default dirs | craft-parts | merged | Merged to implement symlinks for aliased default partitions, fix stage package priming, and update tests. The author proceeded despite failing CI, attributing failures to an external issue (#1171). Approved by three reviewers. | |
| #600 feat(partitions): handle namespaced partitions in utils | craft-parts | merged | Merged following two reviewer approvals and passing CI. Updates utility functions to handle namespaced partitions across eight files (+229/-72 lines). Resolves #596 and CRAFT-2303. | |
| #1123 fix: Prime content from overlay when split into partitions | craft-parts | merged | Merged fix for priming overlay content when split into partitions. Replaces direct overlay reliance with stage directory and migration state. Approved by three reviewers, passed all CI checks, and resolves issue #1127. | |
| #234 executor: fix update build stage packages | craft-parts | merged | Merged a fix for build stage package update consistency and resolved unpacked files disappearing after build updates. Approved by two reviewers, passed CI, and integrated with 49 additions and 26 deletions across five files. | |
| #1617 fix: migrate overlay files before running stage or prime | craft-parts | merged | Merged fix that migrates overlay files before stage or prime steps. Resolves a state tracking bug causing priming failures with symlinks. Approved by reviewers and passed all CI checks. | |
| #1188 refactor: split _check_for_stage_collisions_per_partition | craft-parts | merged | Squash merged after approvals and passing CI. Refactors _check_for_stage_collisions_per_partition by separating file gathering from conflict checking, enabling future overlay conflict resolution without altering current behavior. |