fix: use partitions for stage-packages tracking
Metadata
Current evaluation
Merged PR #834 as 4cbc6006, making stage-package tracking search primed files across partitions and fixing #804 for common cases; duplicate files across partitions remain unsupported.
Resolution: closed resolved
Reason: PR #834 was approved and merged as commit 4cbc6006. Its partition-aware primed-file lookup fixes #804, though the author notes that duplicate files across partitions require deeper refactoring.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This localized fix addresses the issue of stage-package tracking failing in
the presence of partitions by looking for the primed files in each partition.
This solves the most common cases but doesn't fix the issue where a given file
might be present in multiple partitions, as this needs a deeper refactoring of
the state tracking (see discussion in https://github.com/canonical/craft-parts/issues/804).
Fixes https://github.com/canonical/craft-parts/issues/804
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #834 as 4cbc6006, making stage-package tracking search primed files across partitions and fixing #804 for common cases; duplicate files across partitions remain unsupported. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 4cbc6006: stage-package priming now searches each partition, fixing partition-unaware tracking. Files present in multiple partitions still need deeper work. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged fix 4cbc6006 made stage-package tracking partition-aware by finding primed files in each partition, resolving #804 for common cases. Files duplicated across partitions still require refactoring. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix issue #804. The change updates stage-package tracking to scan primed files per partition, resolving failures in common partitioned setups. Multi-partition tracking still requires deeper refactoring. Approved by three reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a localized fix resolving stage-package tracking failures with partitions by scanning primed files per partition. Addresses issue #804 for common cases, though full resolution requires deeper state tracking refactoring. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-parts#804
(confidence 100%)
PR #834 explicitly fixes the partition-unaware stage-package tracking reported in issue #804.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #804 Stage package tracking is unaware of partitions | craft-parts | closed | Stage-package tracking was made partition-aware by commit 4cbc6006, checking primed files across all partition prime directories instead of only the default directory. | |
| #1752 fix: Make `stage-packages` deterministic | craft-parts | merged | Merged PR #1752 in commit 26f4b35e, preserving stage-packages input order during deduplication and APT marking to make resolution deterministic; fixes #1751. | |
| #668 fix: stage and prime content in all partitions by default | craft-parts | merged | Merged in #668 as 85b9ba7a: filesets now stage and prime across all partitions by default and reject ambiguous configurations, fixing #650. | |
| #607 fix(partitions): use base prime dir for getting primed stage packages | craft-parts | closed | Closed unmerged and superseded by the namespaced-partition work merged in #627 via commit 9fe38d11. | |
| #664 fix: stage and prime content in all partitions by default | craft-parts | closed | Closed unmerged in favor of an alternative; PR #668 implemented default all-partition staging and priming and merged as commit 85b9ba7a. | |
| #663 fix: stage and prime content in all partitions by default | craft-parts | closed | PR #663 (fix: stage and prime content in all partitions by default) was closed unmerged in favour of #664; the final fix landed via merged PR #668, commit 85b9ba7a, implementing it in the fileset parser instead of PartSpec validators. |