feat: add rock build planner
Metadata
Current evaluation
Merged PR #25 added default and rock build planners, devel distro support, and explanatory comments; merged as commit d9ff004.
Resolution: closed resolved
Reason: PR #25 was approved and merged into the main project as commit d9ff004, delivering the rock build planner and related CRAFT-3154 changes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
1. Add a default build planner
2. Add a build planner for `rocks`
3. Add support for the special case "devel": `DistroBase.from_str("devel") == DistroBase(ubuntu@devel)`
4. Add explanatory comments in code for #23
See downstream prototypes:
- https://github.com/canonical/rockcraft/pull/662
- https://github.com/canonical/craft-application/pull/403
(CRAFT-3154)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #25 added default and rock build planners, devel distro support, and explanatory comments; merged as commit d9ff004. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Implemented default and rocks build planners, added devel distro base support, and added code comments for #23. Merged by mr-cal. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
canonical/craft-platforms#23
(confidence 98%)
The PR added explanatory comments requested in issue #23.
-
Related To:
canonical/rockcraft#662
(confidence 80%)
Identified in the PR as a downstream prototype.
-
Related To:
canonical/craft-application#403
(confidence 80%)
Identified in the PR as a downstream prototype.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #15 Implement a rock build planner | craft-platforms | closed | Rock build planning was implemented and merged in canonical/craft-platforms#25 via commit d9ff004. | |
| #567 refactor: use default BuildPlanner | rockcraft | merged | Merged in canonical/rockcraft#567 as commit 5f898b32, adopting craft-application’s default BuildPlanner after compatibility changes. | |
| #769 feat: add the remote-build command | rockcraft | merged | Merged PR #769 via commit 8e74936f, adding Rockcraft's experimental remote-build command; documentation followed in PRs #800 and #802. | |
| #362 feat: support platforms for the build plans | rockcraft | merged | Merged PR #362, adding platform support to build plans; the change is recorded in commit 9cc5af95. | |
| #715 refactor: use craft-platform for the build plans | rockcraft | merged | Merged PR #715 (516d29e5) replaced Rockcraft’s custom build-plan generation with craft-platform, creating one shared source for Rockcraft and remote builds; fixes #698. |