refactor: use default BuildPlanner
Metadata
Current evaluation
Merged in canonical/rockcraft#567 as commit 5f898b32, adopting craft-application’s default BuildPlanner after compatibility changes.
Resolution: closed resolved
Reason: PR canonical/rockcraft#567 was merged as commit 5f898b32, replacing Rockcraft’s custom planner with craft-application’s default implementation after prerequisite compatibility work.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
This is a test PR for https://github.com/canonical/craft-application/pull/326, to see if the default BuildPlanner will work for rockcraft.
There are a few pre-requisite commits to be compatible with the latest craft-application.
I wasn't able to get pydantic to use [this](https://github.com/canonical/craft-application/pull/326/files#diff-d49e733a1e99a8cc3fe98cb7d956b735159c60342405692603fe5fcf8a970edaR111) upstream validator but everything else seems to be in working order.
(CRAFT-2824)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#567 as commit 5f898b32, adopting craft-application’s default BuildPlanner after compatibility changes. | |
| stealth/space-bunny-alpha | — | closed resolved | Rockcraft PR #567 was merged to adopt craft-application’s default BuildPlanner, with prerequisite compatibility changes; craft-application#326 supplied the upstream implementation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR adopted craft-application’s default BuildPlanner, added CRAFT-2824 prerequisite compatibility changes, and left upstream Pydantic validation customization unimplemented. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to adopt the default BuildPlanner from craft-application. Approved by two reviewers after verifying upstream compatibility. Minor pydantic validator limitations were noted but did not block integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor to adopt the default BuildPlanner from craft-application. The change validated upstream compatibility, proceeded despite a minor pydantic validator limitation, and passed CI after unrelated test failures were dismissed. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#326
(confidence 98%)
Upstream PR supplied the default BuildPlanner implementation that Rockcraft #567 adopted.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #15 Implement a rock build planner | craft-platforms | closed | Rock build planning was implemented and merged in canonical/craft-platforms#25 via commit d9ff004. | |
| #715 refactor: use craft-platform for the build plans | rockcraft | merged | Merged PR #715 (516d29e5) replaced Rockcraft’s custom build-plan generation with craft-platform, creating one shared source for Rockcraft and remote builds; fixes #698. | |
| #25 feat: add rock build planner | craft-platforms | merged | Merged PR #25 added default and rock build planners, devel distro support, and explanatory comments; merged as commit d9ff004. | |
| #485 Update to craft-application@main | rockcraft | merged | Merged in PR #485, updating to craft-application@main; three commits added BuildPlanner work and removed obsolete Rockcraft code. | |
| #639 Move the build planner logic into craft-platforms | rockcraft | closed | Build planner logic extracted to craft-platforms in merged PR canonical/craft-platforms#25 (commit d9ff004); rockcraft later simplified in commit 5f898b32. Maintainer mr-cal confirmed completion. | |
| #698 Use craft-platforms for build plans | rockcraft | closed | Merged PR #715 (516d29e5) replaced Rockcraft's custom build-plan generation with craft-platforms, resolving #698 and aligning plans with downstream consumers. |