← Back to issue list

refactor: use default BuildPlanner

View original Github issue

Metadata

Project
rockcraft
Number
#567
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged to adopt the default BuildPlanner from craft-application. Approved by two reviewers after verifying upstream compatibility. Minor pydantic validator limitations were noted but did not block integration.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This is a test PR for https://github.com/canonical/craft-application/pull/326, to see if the default BuildPlanner will work for rockcraft. There are a few pre-requisite commits to be compatible with the latest craft-application. I wasn't able to get pydantic to use [this](https://github.com/canonical/craft-application/pull/326/files#diff-d49e733a1e99a8cc3fe98cb7d956b735159c60342405692603fe5fcf8a970edaR111) upstream validator but everything else seems to be in working order. (CRAFT-2824)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to adopt the default BuildPlanner from craft-application. Approved by two reviewers after verifying upstream compatibility. Minor pydantic validator limitations were noted but did not block integration.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor to adopt the default BuildPlanner from craft-application. The change validated upstream compatibility, proceeded despite a minor pydantic validator limitation, and passed CI after unrelated test failures were dismissed.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor adopting the default BuildPlanner from craft-application for rockcraft. Pre-requisite compatibility commits were included. Unrelated CI failures were noted but did not block the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#326 feat: add Platform model and default BuildPlanner craft-application merged Merged after two approvals. Adds a Platform model and default BuildPlanner. The maintainer coordinated timing with related remote-build PRs to bundle fixes in a craft-application hotfix.
71%
#485 Update to craft-application@main rockcraft merged Merged update to craft-application@main, implementing BuildPlanner changes and pruning obsolete code across 16 files. Approved by one reviewer with passing CI checks.
70%