← Back to issue list

lint: fixes for black and pylint

View original Github issue

Metadata

Project
craft-providers
Number
#209
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #209 as 315735b, adding Black 23.1.0 and Pylint 2.16.0 fixes for hotfix/1.7 while keeping Pyright pinned to 1.1.291.

Resolution: closed resolved

Reason: The approved PR was merged as commit 315735b, resolving lint compatibility with the new Black and Pylint releases. A Pyright regression was worked around by retaining snap version 1.1.291.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- It's been a busy 12 hours for the world of Python linting! 2 commits, 1 for the [latest `black` release](https://github.com/psf/black/releases/tag/23.1.0) and 1 for the [latest `pylint` release](https://github.com/PyCQA/pylint/releases/tag/v2.16.0). Targeting `hotfix/1.7` so I can prep a craft-providers release. I will have to post another PR targeting `main` to allow development on the `main` branch to continue.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #209 as 315735b, adding Black 23.1.0 and Pylint 2.16.0 fixes for hotfix/1.7 while keeping Pyright pinned to 1.1.291.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR fixing linting compatibility for latest black (23.1.0) and pylint (v2.16.0) releases. Targeted hotfix/1.7 for craft-providers.

Update history

Date Change
created

Related work

  • Related To: pyright#4564 (confidence 100%)

    The maintainer linked this upstream report as the cause of the temporary Pyright version rollback.

Related issues

Issue Project State Summary Similarity
#208 lint: black formatting craft-providers closed Small black-formatting PR closed unmerged by maintainer mr-cal, who noted a big pylint release and said he would close and reopen a larger PR.
74%
#4029 lint: reformat for black 23.1.0 snapcraft merged Merged PR #4029 (commit 51c24948) reformatting 66 files for Black 23.1.0. The only failing check was a setuptools>=66 unit-test breakage, fixed separately by #4031 pinning setuptools<66.
73%
#3853 lint: lint legacy code with black snapcraft merged Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting.
72%
#3813 lint: bump pylint snapcraft merged Merged in commit 522b301a9: updated Pylint and removed a redundant too-many-lines suppression across three files.
71%