← Back to issue list

lint: reformat for black 23.1.0

View original Github issue

Metadata

Project
snapcraft
Number
#4029
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged following approval. Reformatted 66 files for Black 23.1.0. CI passed. Proceeded with merge despite a known setuptools>=66 test failure affecting other PRs; a separate fix will address it.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Updates for black 2023 changes

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval. Reformatted 66 files for Black 23.1.0. CI passed. Proceeded with merge despite a known setuptools>=66 test failure affecting other PRs; a separate fix will address it.
qwen3.6-35b-a3b-mtp-q6 Merged to reformat code for Black 23.1.0. The maintainer bypassed a unit test failure caused by setuptools>=66 breaking other PRs, merging this change and planning a separate PR to fix the dependency.
qwen3.6-35b-a3b-mtp-q6 Merged to reformat code for Black 23.1.0. The maintainer proceeded despite a unit test failure triggered by setuptools>=66, opening a follow-up PR to address the dependency issue.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3722 static: black update to 22 syntax snapcraft merged Merged update to Black formatter v22 syntax across 55 files. Approved by reviewer, passed CI, and integrated into main despite a minor 0.08% coverage decrease.
73%
#3853 lint: lint legacy code with black snapcraft merged Merged following reviewer approval and passing CI. Applied Black formatting to legacy code across 12 files, resulting in 84 additions and 37 deletions. Code coverage remained stable at 88.16%.
73%
#2599 static: update to newer black snapcraft merged Merged after reviewer approval and passing CI. Updated the codebase to a newer Black formatter version across 15 files (+35/-41 lines). Codecov reported 85.71% diff coverage, flagging a missing base commit upload.
73%
#3865 lint: lint legacy code with black snapcraft merged Merged updates to the test-black lint command to include legacy code, aligning it with autoformat-black. Approved by a maintainer, passed CI checks, and merged without affecting code coverage.
72%
#185 style(black): update black to v24 craft-application merged Merged update to Black v24, modifying pyproject.toml and auto-formatting four files. Approved by two reviewers, passed CI, and maintained 99.28% test coverage.
72%
#638 style: update to black 2024 craft-parts merged Merged Black 2024 formatting updates to resolve CI failures. Approved by two reviewers with passing checks.
71%