← Back to issue list

lint: reformat for black 23.1.0

View original Github issue

Metadata

Project
snapcraft
Number
#4029
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4029 (commit 51c24948) reformatting 66 files for Black 23.1.0. The only failing check was a setuptools>=66 unit-test breakage, fixed separately by #4031 pinning setuptools<66.

Resolution: closed resolved

Reason: The PR was approved and merged into master as commit 51c249486 ("lint: reformat for black 23.1.0 (#4029)"), applying Black 2023 formatting across 66 files. The author noted the sole failure was an unrelated setuptools>=66 unit-test issue, tracked and fixed in merged PR #4031 (commit 709e16c78).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Updates for black 2023 changes

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4029 (commit 51c24948) reformatting 66 files for Black 23.1.0. The only failing check was a setuptools>=66 unit-test breakage, fixed separately by #4031 pinning setuptools<66.
stealth/space-bunny-alpha — closed resolved Merged PR #4029, applying Black 23.1.0 formatting to 66 files in commit 51c249486. Follow-up #4031 pinned setuptools<66 to address the noted unit-test failure.
qwen/qwen3.6-35b-a3b — — Merged following approval. Reformatted 66 files for Black 23.1.0. CI passed. Proceeded with merge despite a known setuptools>=66 test failure affecting other PRs; a separate fix will address it.
qwen3.6-35b-a3b-mtp-q6 — — Merged to reformat code for Black 23.1.0. The maintainer bypassed a unit test failure caused by setuptools>=66 breaking other PRs, merging this change and planning a separate PR to fix the dependency.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4031 (confidence 88%)

    Follow-up PR mentioned in the closing comment; merged as commit 709e16c78 pinning setuptools<66 to fix the unit-test failure that blocked all open PRs, including this one.

Related issues

Issue Project State Summary Similarity
#3722 static: black update to 22 syntax snapcraft merged Merged PR #3722 (branch 'black', commit 3afcb2ade, merge commit 24ce5d5b0) into main, reformatting 55 files for Black 22 syntax; a prerequisite cleanup for the later switch from black to the ruff formatter.
75%
#3853 lint: lint legacy code with black snapcraft merged Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting.
74%
#1491 style(autoformat): update black to 2024 charmcraft merged Merged PR #1491 in commit 15273c6b, updating Black to the 2024 style and reformatting five Python files.
73%
#638 style: update to black 2024 craft-parts merged Merged PR #638 as commit 423ad779, applying Black 2024 formatting to resolve formatting-related CI failures exposed by #627.
73%
#209 lint: fixes for black and pylint craft-providers merged Merged PR #209 as 315735b, adding Black 23.1.0 and Pylint 2.16.0 fixes for hotfix/1.7 while keeping Pyright pinned to 1.1.291.
73%
#3787 lint: apply black to parts directories snapcraft merged Merged PR #3787 in commit 79985df1, applying Black formatting to six files under snapcraft/parts/ and tests/unit/parts/, which Black previously ignored.
72%
#208 lint: black formatting craft-providers closed Small black-formatting PR closed unmerged by maintainer mr-cal, who noted a big pylint release and said he would close and reopen a larger PR.
71%
#2603 black: minor format changes from updated black snapcraft merged Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing.
71%
#2599 static: update to newer black snapcraft merged Merged #2599, applying formatting from a newer Black release across 15 files in commit 05913cd56.
71%
#212 style: replace black formatter with ruff format starbase merged Merged PR #212 as commit aae9d00, replacing Black with Ruff format across seven files (+26/-10).
70%