lint: lint legacy code with black
Metadata
Current evaluation
Merged following reviewer approval and passing CI. Applied Black formatting to legacy code across 12 files, resulting in 84 additions and 37 deletions. Code coverage remained stable at 88.16%.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
lint legacy code with black
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following reviewer approval and passing CI. Applied Black formatting to legacy code across 12 files, resulting in 84 additions and 37 deletions. Code coverage remained stable at 88.16%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Applied Black formatter to legacy code to standardize linting. Code coverage remained unchanged at 88.16%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Applied Black to legacy code for standardized linting. Code coverage remained unchanged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3865 lint: lint legacy code with black | snapcraft | merged | Merged updates to the test-black lint command to include legacy code, aligning it with autoformat-black. Approved by a maintainer, passed CI checks, and merged without affecting code coverage. | |
| #2599 static: update to newer black | snapcraft | merged | Merged after reviewer approval and passing CI. Updated the codebase to a newer Black formatter version across 15 files (+35/-41 lines). Codecov reported 85.71% diff coverage, flagging a missing base commit upload. | |
| #3854 lint: lint legacy code with flake8 | snapcraft | merged | Merged into main following approval and passing CI. The change applies flake8 linting to legacy code across 17 files, modifying 31 additions and 36 deletions. Code coverage remains unchanged. | |
| #3787 lint: apply black to parts directories | snapcraft | merged | Applied Black formatting to previously ignored snapcraft/parts/ and tests/unit/parts/ directories. Merged after reviewer approval and passing CI checks, with no impact on overall code coverage. | |
| #2180 code: use black as the standard style | snapcraft | merged | Merged after approval and CI checks. Adopted Black as the standard code formatter, reformatting 567 files with 39,831 additions and 33,762 deletions. Diff coverage reached 90.92%. | |
| #3722 static: black update to 22 syntax | snapcraft | merged | Merged update to Black formatter v22 syntax across 55 files. Approved by reviewer, passed CI, and integrated into main despite a minor 0.08% coverage decrease. | |
| #3650 lint: apply autoformat-black to source files | snapcraft | merged | Merged following maintainer approval and passing CI. The update modifies the lint configuration to apply autoformat-black exclusively to source files, aligning it with test-black behavior. | |
| #3852 lint: lint legacy code with isort | snapcraft | merged | Merged to re-enable isort linting for legacy code. Approved by a maintainer, passed all checks, and integrated into main without coverage changes. | |
| #1960 style(lint): move from black to ruff | charmcraft | merged | Merged after two approvals and passing CI. Replaced Black with Ruff across 122 files, updating 1778 lines and removing 557 to modernize the linting configuration. | |
| #4029 lint: reformat for black 23.1.0 | snapcraft | merged | Merged following approval. Reformatted 66 files for Black 23.1.0. CI passed. Proceeded with merge despite a known setuptools>=66 test failure affecting other PRs; a separate fix will address it. |