lint: lint legacy code with black
Metadata
Current evaluation
Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting.
Resolution: closed resolved
Reason: PR #3853 was merged into main as commit 806bfd04. It reformatted the legacy code with Black, and the subsequent merged PR #3865 completed Makefile lint coverage for those files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
lint legacy code with black
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3853 as 806bfd04, formatting legacy code with Black across 12 files (+84/-37); coverage remained 88.16%. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following reviewer approval and passing CI. Applied Black formatting to legacy code across 12 files, resulting in 84 additions and 37 deletions. Code coverage remained stable at 88.16%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Applied Black formatter to legacy code to standardize linting. Code coverage remained unchanged at 88.16%. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3865
(confidence 98%)
Merged follow-up that added the legacy files covered by #3853 to the test-black target.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3865 lint: lint legacy code with black | snapcraft | merged | Merged as 789e162 (commit c34b94789): adds legacy code to the Makefile `test-black` target so Black linting matches the `autoformat-black` coverage added earlier in #3853 (806bfd04). | |
| #3650 lint: apply autoformat-black to source files | snapcraft | merged | Merged #3650 to scope autoformat-black to source files, matching test-black; landed in commit 0481269c4. | |
| #3787 lint: apply black to parts directories | snapcraft | merged | Merged PR #3787 in commit 79985df1, applying Black formatting to six files under snapcraft/parts/ and tests/unit/parts/, which Black previously ignored. | |
| #2599 static: update to newer black | snapcraft | merged | Merged #2599, applying formatting from a newer Black release across 15 files in commit 05913cd56. | |
| #3854 lint: lint legacy code with flake8 | snapcraft | merged | Merged PR #3854 (commit 60884d4) applying flake8 lint fixes to 17 snapcraft_legacy files, part of the legacy-code lint sweep alongside #3852 (isort), #3853/#3865 (black). | |
| #2603 black: minor format changes from updated black | snapcraft | merged | Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing. | |
| #315 style: use black for consistent and automated formatting | charmcraft | merged | Merged Black formatting across 36 files, added a formatting test, and ignored flake8 E203/W503 for Black compatibility in charmcraft#315 (merge commit ad135981). | |
| #3722 static: black update to 22 syntax | snapcraft | merged | Merged PR #3722 (branch 'black', commit 3afcb2ade, merge commit 24ce5d5b0) into main, reformatting 55 files for Black 22 syntax; a prerequisite cleanup for the later switch from black to the ruff formatter. | |
| #4029 lint: reformat for black 23.1.0 | snapcraft | merged | Merged PR #4029 (commit 51c24948) reformatting 66 files for Black 23.1.0. The only failing check was a setuptools>=66 unit-test breakage, fixed separately by #4031 pinning setuptools<66. | |
| #638 style: update to black 2024 | craft-parts | merged | Merged PR #638 as commit 423ad779, applying Black 2024 formatting to resolve formatting-related CI failures exposed by #627. |