← Back to issue list

style: fix ruff 0.16 warning

View original Github issue

Metadata

Project
craft-store
Number
#415
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #415 as commit b24d684, adding a directive to ignore Ruff 0.16's new warning; all CI checks passed.

Resolution: closed resolved

Reason: PR #415 was approved and merged as commit b24d684. Its one-line Ruff configuration change resolved the warning, with all reported lint and test checks passing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Ignores a new directive, copied from Starbase. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #415 as commit b24d684, adding a directive to ignore Ruff 0.16's new warning; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR #415 as commit b24d684, adding a Ruff 0.16 warning ignore directive copied from Starbase. All reported CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged after two approvals and passing CI. Resolved a ruff 0.16 warning by adding an ignore directive copied from Starbase. The change added a single line to one file.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Suppresses a new ruff 0.16 linting warning by adding a directive ignore. All CI checks pass, and the PR holds one maintainer approval with zero unresolved comments. Currently awaiting final review and merge.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 5
Confidence: 95
needs review Adds a ruff 0.16 directive ignore copied from Starbase to resolve a new lint warning. All CI checks pass, and the PR has one maintainer approval with zero unresolved comments. Ready to merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Addresses a new ruff 0.16 linting warning by adding an ignore directive. All CI checks pass. Currently awaiting maintainer review.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
85%
#20 style: fix ruff issue craft-platforms merged Merged PR #20 fixed a Ruff linting issue in one file (+1/-3); resolution is commit 71a165d.
84%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
83%
#1323 style: fix new ruff warnings rockcraft merged PR #1323 merged to main: hand-fixed minor new Ruff warnings in 3 files (+30/-20). Lint and all test suites passed; only source-spread-tests failed (unrelated to style change).
83%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
82%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
82%
#1288 style: fix ruff PTH211 errors craft-parts merged Merged as commit 13382674: PR #1288 fixed Ruff 0.13 PTH211 errors across eight files (+29/-30), with all CI checks passing.
82%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
81%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
80%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged in canonical/craft-application#901 via commit 0a659742, fixing Ruff 0.13 linting with a one-line change; review was approved and all CI checks passed.
80%