← Back to issue list

test: make retry unit test more deterministic

View original Github issue

Metadata

Project
craft-providers
Number
#983
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged. Changes refactor a retry unit test for improved determinism. Approved by a reviewer, passed CI checks, and updated one file (+58/-9).

Suggested action:

No scores available.

Issue body

--- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Changes refactor a retry unit test for improved determinism. Approved by a reviewer, passed CI checks, and updated one file (+58/-9).
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 15
Confidence: 85
needs review Updates a retry unit test to improve determinism by removing flakiness. Currently awaiting maintainer review, with no comments or CI status indicated.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 15
Confidence: 90
needs review Adds deterministic behavior to a retry unit test to eliminate flakiness. Currently awaiting maintainer review with no comments or CI status shown.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2876 test: add retry on reactive tests charmcraft open Adds retry logic to flaky reactive tests to reduce test failures. Small change (+6/-2 lines) approved by 1 reviewer, but some CI checks are failing.
73%
#1787 tests: move refresh to unit folder snapcraft merged Merged a fix moving a misplaced refresh test into the unit folder. The test was previously excluded from regular runs due to the new directory structure, causing false passes. Approved by one reviewer, passed CI, and merged.
71%
#1928 tests: remove duplicate tests snapcraft merged Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
71%
#895 test: randomize the order of tests rockcraft merged Merged a pilot implementation to randomize test execution order, preventing inter-test dependencies. Approved by two reviewers with all CI checks passing. Diff adds 16 lines and removes 1 across two files.
70%
#5375 test: fix command tests snapcraft merged Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
70%