← Back to issue list

auth: avoid MemoryKeyring in keyring and raise appropriately (CRAFT-771)

View original Github issue

Metadata

Project
craft-store
Number
#38
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Addressed CRAFT-771 by modifying StoreClient to raise an exception during initialization if no keyring is found, avoiding MemoryKeyring. Approved, passed CI, and merged.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- With this change, the StoreClient raises on __init__ if no keyring is found.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Addressed CRAFT-771 by modifying StoreClient to raise an exception during initialization if no keyring is found, avoiding MemoryKeyring. Approved, passed CI, and merged.
qwen3.6-35b-a3b-mtp-q6 Merged updates to the keyring module to avoid MemoryKeyring. StoreClient now raises an initialization exception when no keyring is available, resolving CRAFT-771.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#75 auth: handle keyring unlocking errors craft-store merged Merged to address CRAFT-1622. Adds error handling for keyring unlocking failures by catching exceptions and raising appropriate Craft-store errors. Approved by two reviewers and passed CI.
80%
#44 store client: use netloc to reference keyring location (CRAFT-799) craft-store merged Merged update to store client using netloc for keyring location references and passing the host parameter to Auth. Removed unused attribute. Existing logins are forgotten as a known side effect. Approved by two reviewers and passed CI.
73%