auth: avoid MemoryKeyring in keyring and raise appropriately (CRAFT-771)
Metadata
Current evaluation
Merged in canonical/craft-store#38 via d7ee75f, preventing automatic MemoryKeyring selection and raising NoKeyringError during StoreClient initialization when no keyring exists.
Resolution: closed resolved
Reason: PR #38 was merged into main in merge commit d7ee75f. Commits 14cee3d and d221bec lower MemoryKeyring's selection priority and raise the appropriate error when no usable keyring is found.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
With this change, the StoreClient raises on __init__ if no keyring is found.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-store#38 via d7ee75f, preventing automatic MemoryKeyring selection and raising NoKeyringError during StoreClient initialization when no keyring exists. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged auth change for CRAFT-771: StoreClient no longer falls back to MemoryKeyring and raises during initialization when no keyring is found. | |
| qwen/qwen3.6-35b-a3b | — | — | Addressed CRAFT-771 by modifying StoreClient to raise an exception during initialization if no keyring is found, avoiding MemoryKeyring. Approved, passed CI, and merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #75 auth: handle keyring unlocking errors | craft-store | merged | Merged PR #75 as commit 74a2ed4, adding keyring unlock error handling that raises a Craft-store error instead of exposing the backend exception. | |
| #58 Keyring failures give bad error messages | craft-store | closed | Keyring failures now raise craft-store's KeyringUnlockError with clearer messaging, fixed by PR #390 (commit d87f1bd). | |
| #163 fix: workaround for keyring 25 incompatibility | craft-store | merged | Merged a one-line workaround for keyring 25 incompatibility in commit 6ef080b, addressing canonical/craft-store#162. | |
| #206 fix: make compatible with keyring 25 | craft-store | merged | Merged canonical/craft-store#206 in commit bdcbf0e, adding a two-file compatibility fix for keyring 25 and resolving issue #162. |