auth: handle keyring unlocking errors
Metadata
Current evaluation
Merged PR #75 as commit 74a2ed4, adding keyring unlock error handling that raises a Craft-store error instead of exposing the backend exception.
Resolution: closed resolved
Reason: PR #75 was merged with two approvals as commit 74a2ed4. The change catches failures while retrieving credentials from an unlocked keyring and raises the appropriate Craft-store exception.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Obtaining the password from the keyring can fail if the keyring is not properly unlocked. In this case, handle the keyring exception and raise an appropriate Craft-store error.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
CRAFT-1622
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #75 as commit 74a2ed4, adding keyring unlock error handling that raises a Craft-store error instead of exposing the backend exception. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #170 in commit ee19448, catching keyring unlock failures and raising a Craft-store error instead of exposing a keyring exception. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to address CRAFT-1622. Adds error handling for keyring unlocking failures by catching exceptions and raising appropriate Craft-store errors. Approved by two reviewers and passed CI. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #390 fix(auth): error more nicely on keyring errors | craft-store | merged | Merged PR #390 (commit d87f1bd) broadens keyring error handling, wrapping more keyring failures as KeyringUnlockError. Fixes #58 and ships in craft-store 3.4.0. | |
| #58 Keyring failures give bad error messages | craft-store | closed | Keyring failures now raise craft-store's KeyringUnlockError with clearer messaging, fixed by PR #390 (commit d87f1bd). | |
| #38 auth: avoid MemoryKeyring in keyring and raise appropriately (CRAFT-771) | craft-store | merged | Merged in canonical/craft-store#38 via d7ee75f, preventing automatic MemoryKeyring selection and raising NoKeyringError during StoreClient initialization when no keyring exists. | |
| #163 fix: workaround for keyring 25 incompatibility | craft-store | merged | Merged a one-line workaround for keyring 25 incompatibility in commit 6ef080b, addressing canonical/craft-store#162. | |
| #170 fix: catch keyring locked error | craft-store | merged | Merged PR #170 added handling for locked keyring errors, fixing #166; merged as commit ee19448. | |
| #206 fix: make compatible with keyring 25 | craft-store | merged | Merged canonical/craft-store#206 in commit bdcbf0e, adding a two-file compatibility fix for keyring 25 and resolving issue #162. | |
| #1741 fix(store): fall back to ephemeral keyring | charmcraft | merged | Merged PR #1741 as commit 5fa2a47c, adding an ephemeral keyring fallback when none is available and fixing #1717. |