auth: handle keyring unlocking errors
Metadata
Current evaluation
Merged to address CRAFT-1622. Adds error handling for keyring unlocking failures by catching exceptions and raising appropriate Craft-store errors. Approved by two reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
Obtaining the password from the keyring can fail if the keyring is not properly unlocked. In this case, handle the keyring exception and raise an appropriate Craft-store error.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
CRAFT-1622
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to address CRAFT-1622. Adds error handling for keyring unlocking failures by catching exceptions and raising appropriate Craft-store errors. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged implementation of keyring unlocking error handling. Catches exceptions and raises specific Craft-store errors, resolving CRAFT-1622. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #38 auth: avoid MemoryKeyring in keyring and raise appropriately (CRAFT-771) | craft-store | merged | Addressed CRAFT-771 by modifying StoreClient to raise an exception during initialization if no keyring is found, avoiding MemoryKeyring. Approved, passed CI, and merged. | |
| #390 fix(auth): error more nicely on keyring errors | craft-store | merged | Merged to improve keyring unlock error handling by catching additional failures and raising them as KeyringUnlockError. Approved by three reviewers, passed all CI checks, and resolves issue #58. | |
| #45 auth: raise error when credentials cannot be parsed (CRAFT-812) | craft-store | merged | Merged changes to craft-store that replace cryptic base64 decoding errors with a clear CredentialsNotParseable exception for invalid credentials. Approved by one reviewer and passed CI. | |
| #58 Keyring failures give bad error messages | craft-store | closed | Transferred to craft-store for generic keyring error handling. Closed and superseded by internal Jira tickets CRAFT-5223 and CRAFT-5224. | |
| #170 fix: catch keyring locked error | craft-store | merged | Merged to resolve issue #166 by catching the keyring locked error. Approved by two reviewers with a two-line change in one file. |