← Back to issue list

style: fix new ruff warnings

View original Github issue

Metadata

Project
rockcraft
Number
#1323
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged after approval by two reviewers. Resolves new ruff linting warnings by manually adjusting code across three files. CI checks passed prior to integration.

Suggested action:

No scores available.

Issue body

Fixes some minor ruff issues by hand. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes. --- <sub>Stack created with <a href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval by two reviewers. Resolves new ruff linting warnings by manually adjusting code across three files. CI checks passed prior to integration.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Addresses new ruff linting warnings by manually fixing code style issues across three files. Currently approved by two reviewers with zero unresolved comments and ready for merge.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
88%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged after two approvals and passing all CI checks. Resolves linting compatibility issues with newer ruff versions, updating five files.
88%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
88%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
87%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
87%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
86%
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
86%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged after approval by two reviewers and passing CI. The change updates the codebase to comply with ruff 0.5 linting rules, adjusting style configurations and fixing formatting across one file.
86%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged a minor style fix addressing linting issues for ruff 0.9. Approved by two reviewers, passed CI checks, and updated two files with a net change of one line.
85%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged a pre-emptive linting update for ruff 0.12 compatibility. Approved by two reviewers and passed CI. The change adjusts formatting across four files to prevent breaking changes when the snap reaches stable.
84%