← Back to issue list

style: fix new ruff warnings

View original Github issue

Metadata

Project
rockcraft
Number
#1323
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

PR #1323 merged to main: hand-fixed minor new Ruff warnings in 3 files (+30/-20). Lint and all test suites passed; only source-spread-tests failed (unrelated to style change).

Resolution: closed resolved

Reason: The pull request itself was the resolution: canonical/rockcraft#1323 was merged with two approving reviewers and 0 unresolved comments, directly fixing the new Ruff lint warnings. Repo history could not be inspected (no pinned commit SHA available), so no merge SHA could be cited.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes some minor ruff issues by hand. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes. --- <sub>Stack created with <a href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1323 merged to main: hand-fixed minor new Ruff warnings in 3 files (+30/-20). Lint and all test suites passed; only source-spread-tests failed (unrelated to style change).
stealth/space-bunny-alpha — closed resolved Merged style cleanup for minor Ruff warnings, changing 3 files (+30/-20); lint passed, while source-spread-tests failed.
qwen/qwen3.6-35b-a3b — — Merged after approval by two reviewers. Resolves new ruff linting warnings by manually adjusting code across three files. CI checks passed prior to integration.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Addresses new ruff linting warnings by manually fixing code style issues across three files. Currently approved by two reviewers with zero unresolved comments and ready for merge.

Update history

Date Change
updated
updated
created

Related work

  • Related To: canonical/rockcraft#907 (confidence 55%)

    Earlier rockcraft PR adjusting ruff linting rules; part of the same recurring ruff-upgrade cleanup series, not a blocker.

  • Related To: canonical/craft-platforms#146 (confidence 40%)

    Sibling canonical repo doing the same ruff-version lint cleanup in the same period; cross-repo precedent only.

Related issues

Issue Project State Summary Similarity
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
85%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
84%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged #165, incorporating canonical/starbase#408, with a four-file Ruff 0.12 compatibility style update (+7/-7).
83%
#415 style: fix ruff 0.16 warning craft-store merged Merged PR #415 as commit b24d684, adding a directive to ignore Ruff 0.16's new warning; all CI checks passed.
83%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
83%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed.
82%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers.
82%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
82%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
82%
#20 style: fix ruff issue craft-platforms merged Merged PR #20 fixed a Ruff linting issue in one file (+1/-3); resolution is commit 71a165d.
81%