fix: catch keyring locked error
Metadata
Current evaluation
Merged PR #170 added handling for locked keyring errors, fixing #166; merged as commit ee19448.
Resolution: closed resolved
Reason: PR #170 was approved and merged as commit ee19448, adding handling for keyring.errors.KeyringLocked and resolving issue #166.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes: #166
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #170 added handling for locked keyring errors, fixing #166; merged as commit ee19448. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-store#170 as commit ee19448, adding handling for keyring locked errors and resolving #166. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-store#170 (commit ee19448), catching KeyringLocked errors to prevent an unhandled traceback and fix #166. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to resolve issue #166 by catching the keyring locked error. Approved by two reviewers with a two-line change in one file. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-store#166
(confidence 100%)
Reported the uncaught KeyringLocked traceback and was explicitly fixed by PR #170.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #166 `keyring.errors.KeyringLocked` is not caught and produces a traceback | craft-store | closed | Locked keyrings now produce a handled keyring-misconfiguration error instead of a traceback. Fixed by merged PR #170 in commit ee19448. | |
| #390 fix(auth): error more nicely on keyring errors | craft-store | merged | Merged PR #390 (commit d87f1bd) broadens keyring error handling, wrapping more keyring failures as KeyringUnlockError. Fixes #58 and ships in craft-store 3.4.0. | |
| #75 auth: handle keyring unlocking errors | craft-store | merged | Merged PR #75 as commit 74a2ed4, adding keyring unlock error handling that raises a Craft-store error instead of exposing the backend exception. | |
| #163 fix: workaround for keyring 25 incompatibility | craft-store | merged | Merged a one-line workaround for keyring 25 incompatibility in commit 6ef080b, addressing canonical/craft-store#162. | |
| #1741 fix(store): fall back to ephemeral keyring | charmcraft | merged | Merged PR #1741 as commit 5fa2a47c, adding an ephemeral keyring fallback when none is available and fixing #1717. | |
| #206 fix: make compatible with keyring 25 | craft-store | merged | Merged canonical/craft-store#206 in commit bdcbf0e, adding a two-file compatibility fix for keyring 25 and resolving issue #162. |