← Back to issue list

fix: catch keyring locked error

View original Github issue

Metadata

Project
craft-store
Number
#170
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged to resolve issue #166 by catching the keyring locked error. Approved by two reviewers with a two-line change in one file.

Suggested action: —

No scores available.

Issue body

Fixes: #166

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged to resolve issue #166 by catching the keyring locked error. Approved by two reviewers with a two-line change in one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix that catches keyring locked errors, resolving issue #166. Authored by maintainer syu-w, the change was successfully integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#163 fix: workaround for keyring 25 incompatibility craft-store merged Merged a one-line workaround to resolve keyring 25 incompatibility. Approved by two reviewers and passed CI checks, addressing issue #162.
82%
#390 fix(auth): error more nicely on keyring errors craft-store merged Merged to improve keyring unlock error handling by catching additional failures and raising them as KeyringUnlockError. Approved by three reviewers, passed all CI checks, and resolves issue #58.
80%
#206 fix: make compatible with keyring 25 craft-store merged Merged to resolve issue #162 by updating code for keyring 25 compatibility. Approved by three reviewers, the change modifies two files with minimal adjustments (+3/-2 lines) and was successfully integrated.
79%
#50 keys: handle keyring path parents not existing craft-archives merged Merged changes to handle non-existent keyring path parents. Approved by two reviewers, modified three files (+19/-4), and achieved 100% diff coverage. Required for rockcraft PR #217.
72%
#75 auth: handle keyring unlocking errors craft-store merged Merged to address CRAFT-1622. Adds error handling for keyring unlocking failures by catching exceptions and raising appropriate Craft-store errors. Approved by two reviewers and passed CI.
71%
#1741 fix(store): fall back to ephemeral keyring charmcraft merged Implemented a fallback to an ephemeral keyring when none is available, resolving issue #1717. Merged after approval by two reviewers. Changes affect two files with 39 additions and 8 deletions.
71%