← Back to issue list

style: drop mypy, pyright

View original Github issue

Metadata

Project
craft-store
Number
#421
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #421 to replace mypy and pyright with Astral ty; the lint pipeline now runs lint-ty.

Resolution: closed resolved

Reason: canonical/craft-store#421 was merged after approval from two reviewers, with all CI checks passing. The merged change updates lint-code to use lint-ty and removes mypy and pyright.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Drops mypy and pyright in favor of ty. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #421 to replace mypy and pyright with Astral ty; the lint pipeline now runs lint-ty.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-store#421 in commit 2d1b165, replacing mypy and pyright with ty after two approvals; all reported CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-store#421, dropping mypy and pyright in favor of ty; all CI checks passed after approval from two reviewers.
qwen/qwen3.8-27b — — Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 15
Staleness: 5
Complexity: 25
Confidence: 90
needs review Drops mypy and pyright type checkers in favor of ty across Makefile, common.mk, pyproject.toml and uv.lock (13 files, +27/-413). Fresh maintainer PR with 1 approval, all CI checks passing, ready to land.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 95
needs review Replaces mypy and pyright type checkers with ty across 13 files. PR is approved by one reviewer, all CI checks pass, and it is ready for final maintainer review and merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Replaces mypy and pyright type checkers with ty across 13 files. All CI checks pass. Currently pending maintainer review with no comments or approvals yet.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Replaces mypy and pyright type checkers with ty across 13 files. All CI checks pass. Currently pending maintainer review with no comments or approvals yet.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 20
Confidence: 90
needs review Replaces mypy and pyright with ty across 13 files. PR is fresh, CI passes, and pending maintainer review.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 85
needs review Replaces mypy and pyright type checkers with ty across 13 files. Currently pending maintainer review with no CI checks or comments yet.

Update history

Date Change
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
87%
#253 style: drop mypy, pyright craft-archives merged Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
81%
#152 style: remove mypy and pyright to go all-in on ty debcraft merged Merged canonical/debcraft#152, removing mypy and pyright and standardizing type checking on Astral ty after approval by two reviewers.
80%
#207 style: disable pyright in favour of ty craft-platforms merged Merged as f287a56, replacing the active Pyright configuration with Astral’s ty type checker.
80%
#1007 style: drop mypy, pyright craft-providers merged Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.
79%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
79%
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
78%
#6132 Linting breaks mypy snapcraft closed Superseded by merged PR #6247 (commit 534d7dce7), which replaced mypy linting with Astral ty; the missing-mypy failure no longer applies.
77%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
76%
#479 style: drop mypy, pyright craft-cli merged Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
75%