← Back to issue list

style: drop mypy, pyright

View original Github issue

Metadata

Project
craft-store
Number
#421
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files.

Suggested action: —

No scores available.

Issue body

Drops mypy and pyright in favor of ty. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b — — Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 15.0
Staleness: 5
Complexity: 25
Confidence: 90
needs review Drops mypy and pyright type checkers in favor of ty across Makefile, common.mk, pyproject.toml and uv.lock (13 files, +27/-413). Fresh maintainer PR with 1 approval, all CI checks passing, ready to land.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 95
needs review Replaces mypy and pyright type checkers with ty across 13 files. PR is approved by one reviewer, all CI checks pass, and it is ready for final maintainer review and merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Replaces mypy and pyright type checkers with ty across 13 files. All CI checks pass. Currently pending maintainer review with no comments or approvals yet.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Replaces mypy and pyright type checkers with ty across 13 files. All CI checks pass. Currently pending maintainer review with no comments or approvals yet.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 20
Confidence: 90
needs review Replaces mypy and pyright with ty across 13 files. PR is fresh, CI passes, and pending maintainer review.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 85
needs review Replaces mypy and pyright type checkers with ty across 13 files. Currently pending maintainer review with no CI checks or comments yet.

Update history

Date Change
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#479 style: drop mypy, pyright craft-cli merged Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
98%
#253 style: drop mypy, pyright craft-archives merged Merged after approval and passing CI. Removes mypy and pyright, replacing them with ty; 13 files changed (+16/-506).
93%
#1706 style: drop mypy, pyright craft-parts merged Merged after approval and passing CI. Replaced mypy and pyright with ty for type checking across 88 files. Redundant isinstance checks were deferred to a separate issue.
91%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged after approval by two reviewers and passing CI checks. Replaces mypy and pyright with the ty type checker across three files, reducing 266 lines.
90%
#215 style: drop mypy, pyright craft-grammar merged Merged a pull request replacing mypy and pyright with the ty type checker. After passing all CI checks and receiving two approvals, the change was successfully integrated, removing 481 lines of configuration across six files.
89%
#152 style: remove mypy and pyright to go all-in on ty debcraft merged Merged changes removing mypy and pyright type checkers to exclusively use the ty tool. Approved by two reviewers, passed CI checks, and modified 12 files with a net reduction of 154 lines.
87%
#1007 style: drop mypy, pyright craft-providers merged Removes mypy and pyright type checkers in favor of ty, updating Makefile, common.mk, pyproject.toml, and uv.lock across 16 files (+24/-241). Fresh maintainer PR, CI green, pending review; directly implements issue #901.
82%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged changes replacing mypy and pyright linting tools with ty. Approved by three reviewers and passed CI checks. Updates 43 files to streamline linting configuration and prepare for Starbase integration.
81%
#1084 style: replace mypy and pyright with ty craft-application merged Merged a squashed pull request replacing mypy and pyright with ty for type checking across 70 files. Approved by two reviewers with all CI checks passing, the change streamlines the linting configuration for craft-app 7.
81%
#856 style: update mypy and fix linting issues craft-application merged Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions.
80%