← Back to issue list

Refactor inspector interaction strategy

View original Github issue

Metadata

Project
fetch-service
Number
#23
Type
issue
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Opinion-based inspector communication was implemented for apt/deb artifact checks in merged PR canonical/fetch-service#61 (commit 566f57c), resolving #23.

Resolution: closed resolved

Reason: PR canonical/fetch-service#61 was merged as commit 566f57c, adding the apt/deb inspector implementation that passes information through opinions without direct inspector communication.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done There must be no direct communication between inspectors. Instead, information is passed through opinions. (E.g. the apt inspector also verifies deb packages to verify presence in apt metadata before the artefact is examined by the deb inspector.) ### Why it needs to get done It establishes a simpler workflow that can be maintained with less effort than ad-hoc APIs defined in each inspector.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Opinion-based inspector communication was implemented for apt/deb artifact checks in merged PR canonical/fetch-service#61 (commit 566f57c), resolving #23.
stealth/space-bunny-alpha — closed resolved Opinion-based inspector communication was implemented with stateful apt and deb inspectors in merged PR canonical/fetch-service#61 (566f57c); #23 was later closed.
qwen/qwen3.6-35b-a3b — — Closed without comments or resolution. The proposed refactor to route inspector communication through opinions was abandoned or superseded by later architectural changes.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/fetch-service#61 (confidence 98%)

    Merged implementation associated with closing issue #23.

  • Related To: canonical/fetch-service#26 (confidence 82%)

    Commit b0e6cac introduced artifact validation through opinions, supporting the requested interaction model.

Related issues

Issue Project State Summary Similarity
#606 refactor: set inspector opinion and artifact metadata fetch-service merged Merged in canonical/fetch-service#606 (commit d73ca4a), combining inspector opinion and artifact metadata updates to prevent metadata loss or omissions.
75%
#16 inspectors: refactor to inspect requests and collect opinions fetch-service merged Merged as commit 68fe099: reorganised inspection flow, added inspect requests and an opinion system replacing artefact annotations. Fixes #15; per-inspector migration followed in #26, #28, #41.
72%
#82 metadata,inspectors: refactor artefact inspection interface fetch-service merged Merged PR #82 in commit a05ab1e, splitting request/response inspection methods, removing redundant APIs and attributes, and moving opinions to a dedicated package.
70%