← Back to issue list

inspectors: refactor to inspect requests and collect opinions

View original Github issue

Metadata

Project
fetch-service
Number
#16
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 68fe099: reorganised inspection flow, added inspect requests and an opinion system replacing artefact annotations. Fixes #15; per-inspector migration followed in #26, #28, #41.

Resolution: closed resolved

Reason: The PR was merged into the mainline as commit 68fe099 ("inspectors: refactor to inspect requests and collect opinions (#16)"), approved with no unresolved review comments, and closed tracked issue #15 by introducing inspect-request/opinion APIs. The remaining per-inspector migration was delivered by merged PRs #26 (b0e6cac), #28 (7f8029b) and #41 (f687096).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Reorganize the inspection flow and artefact metadata structure to consolidate the previously separate pieces of metadata for files and downloads, inspect requests, and collect opinions from inspectors to approve or reject a file or download. The newly created opinion system replaces artefact annotations as they serve a similar purpose. Individual inspectors will be refactored separately to use the new validation subsystem. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Fixes #15

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 68fe099: reorganised inspection flow, added inspect requests and an opinion system replacing artefact annotations. Fixes #15; per-inspector migration followed in #26, #28, #41.
qwen/qwen3.6-35b-a3b — closed resolved Refactored inspection flow and artefact metadata to consolidate file/download metadata, inspect requests, and collect opinions from inspectors, replacing artefact annotations. Fixes #15.

Update history

Date Change
created

Related work

  • Related To: fetch-service#15 (confidence 95%)

    Tracked issue declared fixed by this PR; closed as superseded/completed by PRs #41, #28 and #26.

  • Likely Fixed By: fetch-service#26 (confidence 90%)

    Follow-up merge (commit b0e6cac) completing the opinion-based validation refactor started here: inspectors emit opinions for all related formats.

  • Likely Fixed By: fetch-service#28 (confidence 88%)

    Follow-up merge (commit 7f8029b) making request inspection approval explicit, aligning with the opinion model introduced in #16.

  • Likely Fixed By: fetch-service#41 (confidence 88%)

    Follow-up merge (commit f687096) adding request opinions and pending-verification artefact metadata.

  • Related To: fetch-service#606 (confidence 70%)

    Much later commit d73ca4a "refactor: set inspector opinion and artifact metadata (#606)" continues the same inspector opinion/metadata design.

Related issues

Issue Project State Summary Similarity
#82 metadata,inspectors: refactor artefact inspection interface fetch-service merged Merged PR #82 in commit a05ab1e, splitting request/response inspection methods, removing redundant APIs and attributes, and moving opinions to a dedicated package.
82%
#41 inspectors: add request opinions fetch-service merged Merged request inspection opinions via PR #41 (commit f687096), adding metadata support for placing artefacts in a pending-verification state.
78%
#26 inspectors: validate artefacts using opinions fetch-service merged Merged PR #26 (commit b0e6cac) replaced single-format inspection with an opinion-based scheme: all inspectors examine related formats and emit opinions; an artefact is validated only if every capable inspector approves. Fixes fetch-service#23 (CRAFT-2114).
77%
#158 metadata,inspectors: fix inspection result and add tests fetch-service merged Merged in canonical/fetch-service#158 via commits 87f24f5 and f811522; artefact approval now requires a positive request-inspection opinion, with expanded metadata tests.
74%
#37 inspectors: add request opinions fetch-service closed Request-opinion metadata work was dropped from #37 and merged via #41 in commit f687096.
74%
#35 inspectors: simplify request authorization fetch-service merged Merged PR #35 simplified inspector request authorization across 11 files (+43/-40) in commit 75be218.
72%
#23 Refactor inspector interaction strategy fetch-service closed Opinion-based inspector communication was implemented for apt/deb artifact checks in merged PR canonical/fetch-service#61 (commit 566f57c), resolving #23.
72%
#302 refactor(inspectors): reduce cyclomatic complexity fetch-service merged Merged as commit 6437810: reduced inspector complexity, moved artifact operations into Artefact, and made Git protocol decoding errors reject artifacts; fixes #292.
72%
#58 docs: add new inspector howto fetch-service merged Merged PR #58 added a how-to covering common inspector operations; it landed as commit bc6d60b.
71%
#606 refactor: set inspector opinion and artifact metadata fetch-service merged Merged in canonical/fetch-service#606 (commit d73ca4a), combining inspector opinion and artifact metadata updates to prevent metadata loss or omissions.
71%