metadata,inspectors: refactor artefact inspection interface
Metadata
Current evaluation
Merged PR #82 in commit a05ab1e, splitting request/response inspection methods, removing redundant APIs and attributes, and moving opinions to a dedicated package.
Resolution: closed resolved
Reason: PR #82 was approved by two reviewers and merged. Commit a05ab1e implements the artefact inspection interface refactor across metadata and inspectors.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Refactor artefact inspection methods and inspector interface,
removing redundant methods and ambiguous method names. Add
separate request and response inspection methods, and remove
unnecessary attributes. Move opinions to their own package.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #82 in commit a05ab1e, splitting request/response inspection methods, removing redundant APIs and attributes, and moving opinions to a dedicated package. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #82 merged, refactoring artefact inspection, splitting request/response methods, removing redundant attributes, and moving opinions to a dedicated package. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after refactoring the artefact inspection interface. Redundant methods were removed, separate request and response inspection methods were added, and opinions were moved to a dedicated package. Approved and passed CI. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #16 inspectors: refactor to inspect requests and collect opinions | fetch-service | merged | Merged as commit 68fe099: reorganised inspection flow, added inspect requests and an opinion system replacing artefact annotations. Fixes #15; per-inspector migration followed in #26, #28, #41. | |
| #158 metadata,inspectors: fix inspection result and add tests | fetch-service | merged | Merged in canonical/fetch-service#158 via commits 87f24f5 and f811522; artefact approval now requires a positive request-inspection opinion, with expanded metadata tests. | |
| #41 inspectors: add request opinions | fetch-service | merged | Merged request inspection opinions via PR #41 (commit f687096), adding metadata support for placing artefacts in a pending-verification state. | |
| #26 inspectors: validate artefacts using opinions | fetch-service | merged | Merged PR #26 (commit b0e6cac) replaced single-format inspection with an opinion-based scheme: all inspectors examine related formats and emit opinions; an artefact is validated only if every capable inspector approves. Fixes fetch-service#23 (CRAFT-2114). | |
| #140 many: limit inspector access to artefact metadata | fetch-service | merged | Merged PR #140 in commit 19fd664, adding request/response interfaces that restrict inspectors to authorized artefact metadata updates and prevent invalid opinion states. | |
| #143 inspectors: reorganize artefact file interface | fetch-service | merged | Merged as 9d8a634, renaming the artefact file interface to distinguish it from the implementation struct and clarify its read-only role. | |
| #302 refactor(inspectors): reduce cyclomatic complexity | fetch-service | merged | Merged as commit 6437810: reduced inspector complexity, moved artifact operations into Artefact, and made Git protocol decoding errors reject artifacts; fixes #292. | |
| #606 refactor: set inspector opinion and artifact metadata | fetch-service | merged | Merged in canonical/fetch-service#606 (commit d73ca4a), combining inspector opinion and artifact metadata updates to prevent metadata loss or omissions. | |
| #23 Refactor inspector interaction strategy | fetch-service | closed | Opinion-based inspector communication was implemented for apt/deb artifact checks in merged PR canonical/fetch-service#61 (commit 566f57c), resolving #23. |