← Back to issue list

feat: Support overlay

View original Github issue

Metadata

Project
imagecraft
Number
#110
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged in imagecraft#110 (00f1348), enabling overlays and empty bases with spread coverage for overlays combined with partitions; fixes #98.

Resolution: closed resolved

Reason: PR imagecraft#110 was merged as commit 00f1348 after approval and explicitly fixes imagecraft#98. It enabled overlay support, permitted an empty base, and added coverage for using overlays with partitions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- - Enable the overlay feature - Provide a bare/empty base - Add a spread test using both overlay and partitions features. Fixes #98 CRAFT-4269

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in imagecraft#110 (00f1348), enabling overlays and empty bases with spread coverage for overlays combined with partitions; fixes #98.
stealth/space-bunny-alpha — closed resolved Merged as imagecraft#110 (commit 00f1348), enabling overlays with a bare base and spread coverage for overlays plus partitions; fixes imagecraft#98.
qwen/qwen3.6-35b-a3b — — Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable the overlay feature with a bare/empty base and spread tests. Resolves #98 and CRAFT-4269.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: imagecraft#98 (confidence 100%)

    PR #110 explicitly states that it fixes the overlay feature issue.

  • Likely Fixed By: craft-parts#1035 (confidence 99%)

    Merged as commit b575539e, it reconciled overlay and partition features, unblocking the implementation.

  • Blocked By: craft-parts#1028 (confidence 98%)

    The upstream inability to enable partitions and overlays simultaneously blocked imagecraft#98.

Related issues

Issue Project State Summary Similarity
#98 Enable overlay feature imagecraft closed Overlay support was implemented in imagecraft PR #110 (commit 00f1348), after craft-parts PR #1035 (b575539e) removed the partition/overlay blocker.
80%
#299 feat: enable override-overlay imagecraft merged Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support.
75%
#113 overlay: add overlay support to parts (CRAFT-470) craft-parts merged Merged #113 via commit 2d90e608, adding overlay work-directory definitions, overlay subdirectory properties, and detection of overlay parameters and visibility for CRAFT-470.
72%
#1165 feat: enable override-overlay rockcraft merged Merged in rockcraft#1165 via commit 1024f092, enabling override-overlay, updating a spread test from overlay-script, and documenting the key.
70%