← Back to issue list

feat: Support overlay

View original Github issue

Metadata

Project
imagecraft
Number
#110
Type
pull request
State
merged
Author
upils
Labels
Created
Updated
Closed

Current evaluation

Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- - Enable the overlay feature - Provide a bare/empty base - Add a spread test using both overlay and partitions features. Fixes #98 CRAFT-4269

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files.
qwen3.6-35b-a3b-mtp-q6 Merged to enable the overlay feature with a bare/empty base and spread tests. Resolves #98 and CRAFT-4269.
qwen3.6-35b-a3b-mtp-q6 Merged. Implemented overlay feature support with a bare/empty base and spread tests. Resolves #98 and CRAFT-4269.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#299 feat: enable override-overlay imagecraft merged Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test.
87%
#1472 feat: add override-overlay craft-parts merged Merged the override-overlay feature. Approved by two reviewers with 180 additions and 35 deletions across 10 files. Passed required CI checks and was successfully integrated into the codebase.
79%
#407 features: reorganize overlay feature tests craft-parts merged Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI.
78%
#602 fix: enable overlays in _enable_craft_parts_features() rockcraft merged Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated.
78%
#1165 feat: enable override-overlay rockcraft merged Merged. Updates craft-parts to enable the override-overlay key, replaces overlay-script in tests, and updates documentation. Reviewers approved the changes and confirmed upgrading sphinx-terminal resolves linting errors. All required checks passed before merge.
76%
#349 test: add overlay plugin integration test imagecraft merged Merged following successful CI checks and dual reviewer approval. The update adds integration tests for overlay plugin commands and bumps the craft-parts dependency across eight files.
75%
#111 overlay: add overlayfs helpers (CRAFT-462) craft-parts merged Merged. Added overlayfs mount and unmount helpers, plus utilities to identify special files and directories for filesystem layering. Approved by two reviewers, passed CI, and introduced 420 lines across six files.
74%
#775 feat: add support to spread test expressions craft-application merged Merged feature adding spread test expression support to the test command. Filters jobs by craft backend and CI host system. Approved by two reviewers and merged despite unreviewed commits and a failing OSV-scanner check. Fixes #748.
74%
#336 features: introduce craft-parts features craft-parts merged Merged pull request introducing a configurable feature system to craft-parts, including an initial overlay feature implementation. Approved by reviewer, passed CI, and merged with 620 additions and 12 deletions across 14 files.
73%
#1035 feat: reconcile overlays and partition features craft-parts merged Merged. Implements simultaneous overlay and partition feature support, resolving issue #1028. Approved by three reviewers with passing CI. Further tests and refactoring will follow in a subsequent PR.
73%