tests/spread: retry restore cleanup for pack tests
Metadata
Current evaluation
PR #400 was closed unmerged after 43 days; retry loops for loop-device cleanup and imagecraft clean in five spread pack tests were not applied.
Resolution: closed stale
Reason: The PR was closed unmerged after 43 days with no approving review or closing explanation. Targeted restore scripts still perform one-shot cleanup, confirming the proposed retries were abandoned.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Wraps loop-device unmount/detach and `imagecraft clean --destructive-mode` in retry loops in the `grub`, `mbr-grub`, `grub-boot-partition`, `mbr-grub-boot-partition`, and `organize-overlay` pack test restore scripts, so transient "device busy" errors under host load don't hard-fail the restore step.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #400 was closed unmerged after 43 days; retry loops for loop-device cleanup and imagecraft clean in five spread pack tests were not applied. | |
| stealth/space-bunny-alpha | — | closed stale | canonical/imagecraft#400 was closed unmerged after 43 days, leaving the proposed pack-test cleanup retry changes unapplied. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to pending review, unresolved comments, and a failing CI check. The change proposed retry loops for pack test cleanup to handle transient device busy errors. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned and closed without merging due to unresolved review comments and failing CI checks. The PR adds retry loops to pack test restore scripts to prevent transient device busy errors from failing cleanup. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
20
Confidence:
85
|
needs review | Adds retry loops to cleanup scripts for several pack tests to handle transient device busy errors during unmount and imagecraft cleanup. Currently pending review with 8 unresolved comments and spread tests running. |
Update history
| Date | Change |
|---|---|
| closed | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #399 test(spread): retry restore cleanup for pack tests | imagecraft | closed | PR #399 was closed unmerged after 51 days with seven unresolved review comments and one failing spread job; its restore-cleanup retry changes were not incorporated. | |
| #944 test(spread): speed up the skip-retest spread test | craft-application | closed | PR #944 was closed unmerged and superseded by craft-application#964, which carried the spread-test speedup changes forward and merged the adjusted repack-test setup. | |
| #486 test(spread): clean up plugin prep/restore | imagecraft | merged | Merged PR #486 refactors spread tests by moving plugin preparation and restoration logic into common prepare-each and restore-each scripts, reducing task file size and improving maintainability. |