test(spread): retry restore cleanup for pack tests
Metadata
Current evaluation
PR #399 was closed unmerged after 51 days with seven unresolved review comments and one failing spread job; its restore-cleanup retry changes were not incorporated.
Resolution: closed stale
Reason: The PR remained pending review with seven unresolved comments and a failing spread job before being closed without a recorded resolution or maintainer explanation. No merge commit or superseding work was identified.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Some `tests/spread/pack/*` restore scripts (`grub`, `mbr-grub`, `grub-boot-partition`, `mbr-grub-boot-partition`, `organize-overlay`) clean up loop-device mounts and run `imagecraft clean --destructive-mode` with commands (`umount`, `losetup -d`, `imagecraft clean`) that can transiently fail with a busy resource under host load. When that happens, the whole restore step hard-fails and leaves the test environment dirty for subsequent tasks (seen as `Failed task restore` in spread runs against the multipass backend).
This PR wraps those cleanup commands in short retry loops so a transient busy error doesn't fail the restore outright.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #399 was closed unmerged after 51 days with seven unresolved review comments and one failing spread job; its restore-cleanup retry changes were not incorporated. | |
| stealth/space-bunny-alpha | — | closed stale | PR #399 was closed unmerged after 51 days, leaving seven unresolved review threads and no documented replacement or resolution. | |
| stealth/space-bunny-alpha | — | closed stale | Retry cleanup for spread pack restore scripts was proposed, but was not merged; review was pending with seven unresolved comments, and one spread job was failing. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The change adds retry loops to spread pack test cleanup scripts to handle transient busy resource errors. It remains pending review with seven unresolved comments and a failing CI check. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #400 tests/spread: retry restore cleanup for pack tests | imagecraft | closed | PR #400 was closed unmerged after 43 days; retry loops for loop-device cleanup and imagecraft clean in five spread pack tests were not applied. | |
| #944 test(spread): speed up the skip-retest spread test | craft-application | closed | PR #944 was closed unmerged and superseded by craft-application#964, which carried the spread-test speedup changes forward and merged the adjusted repack-test setup. | |
| #486 test(spread): clean up plugin prep/restore | imagecraft | merged | Merged PR #486 refactors spread tests by moving plugin preparation and restoration logic into common prepare-each and restore-each scripts, reducing task file size and improving maintainability. | |
| #2785 test(spread): fix different-dir task assertions | charmcraft | open | Maintainer PR (2 files, +6/-5) updating spread different-dir / different-dir-metadata assertions to match where artifacts land with --project-dir, plus restore cleanup. Fixes tests failing on main; CI green, 2 checks pending, 1 review comment unresolved, idle 80 days. | |
| #926 test: address a couple of non-flaky spread failures | rockcraft | merged | Merged PR #926 updated three spread-test configuration files to address persistent failures; all CI checks passed and two reviewers approved. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. |