← Back to issue list

test(spread): clean up plugin prep/restore

View original Github issue

Metadata

Project
imagecraft
Number
#486
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #486 refactors spread tests by moving plugin preparation and restoration logic into common prepare-each and restore-each scripts, reducing task file size and improving maintainability.

Resolution: closed resolved

Reason: The PR was merged into the main branch, successfully refactoring the spread test infrastructure to use common prepare-each and restore-each scripts for plugin tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This moves the common work for plugin spread tests into the suite's `prepare-each` and `restore-each` scripts and makes the environment common, reducing the size of the task files so they can focus on the most important bits. CRAFT-5332 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #486 refactors spread tests by moving plugin preparation and restoration logic into common prepare-each and restore-each scripts, reducing task file size and improving maintainability.
~deepseek/deepseek-pro-latest
Impact: 20
Quick Win: 15
Complexity: 20
Confidence: 85
Actionability: 95
needs review Moves common plugin spread test prep/restore into suite prepare-each/restore-each scripts and a common environment; approved, CI passing.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 11
Complexity: 15
Confidence: 75
Actionability: 85
needs review Moves common plugin spread-test setup/teardown into suite-level prepare-each/restore-each scripts and a shared environment, slimming three task files. Approved; CI green except one pending boot-arm-classic spread check.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 7
Complexity: 20
Confidence: 55
Actionability: 60
needs review Refactors plugin spread tests to share setup/teardown via suite prepare-each/restore-each scripts, shrinking 3 task files. Approved with 1 unresolved comment; boot-arm-classic CI check failing (unrelated).
~deepseek/deepseek-pro-latest
Impact: 25
Quick Win: 15
Complexity: 20
Confidence: 75
Actionability: 75
needs review Moves plugin spread test prep/restore into suite-level prepare-each/restore-each and common environment, shrinking three plugin task files; spread checks pending, other CI passing.
~deepseek/deepseek-pro-latest
Impact: 25
Quick Win: 14
Complexity: 25
Confidence: 70
Actionability: 75
needs review Moves plugin spread test prep/restore into suite-level prepare-each/restore-each and common environment, shrinking three plugin task files. Spread checks pending; other CI passing.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 9
Complexity: 20
Confidence: 75
Actionability: 72
needs review Moves common plugin spread-test setup/teardown into suite prepare-each/restore-each scripts and a shared environment, shrinking task files. Test-only refactor; open, awaiting review.

Update history

Date Change
merged
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files.
80%
#3432 spread tests: remove legacy plugin tests snapcraft merged PR #3432 (commit 950fa2508, f2c9caa04) merged: deleted 665 lines of legacy plugin spread tests across 29 files, removing outdated plugin coverage without affecting code coverage (90.83%).
78%
#2199 tests: add spread suite for copy plugin snapcraft merged Merged PR #2199 (f62504d) moved copy-plugin integration tests into a Spread suite, resolving LP #1783831.
74%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.
74%
#2211 tests: add spread suite for ament plugin snapcraft merged Merged PR #2211 as commit bdaa8ea5, replacing the Ament plugin snapd integration test with a Spread suite and resolving LP #1783827.
74%
#399 test(spread): retry restore cleanup for pack tests imagecraft closed PR #399 was closed unmerged after 51 days with seven unresolved review comments and one failing spread job; its restore-cleanup retry changes were not incorporated.
73%
#1290 test(spread): clean up store tests charmcraft merged Merged in commit 34ab4bdd, cleaning up store spread tests by deleting 28 lines across four files; the remaining library-test failure was fixed separately in #1292.
73%
#2173 tests: create basic integration test spread infrastructure snapcraft merged Merged PR #2173 in commit ad7260ced, adding Spread integration-test infrastructure and porting the Go plugin integration test; it resolved LP #1779419.
73%
#2182 tests: add spread suite for autotools plugin snapcraft merged PR #2182 merged to master as commit eadd86729, consolidating the Autotools plugin and snapd tests into a single Spread suite and resolving LP bug #1783825.
72%
#13 test(spread): add more spread tests snapcraft-rocks merged Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files).
72%