← Back to issue list

fix(cli): refer to rockcraft.yaml in expand-extensions help

View original Github issue

Metadata

Project
rockcraft
Number
#1117
Type
pull request
State
closed
Author
gcomneno
Labels
—
Created
Updated
Closed

Current evaluation

Docs-only PR correcting the expand-extensions help text to say rockcraft.yaml. Closed unmerged by the author after maintainer @asanvaq noted it duplicated the work in #1103 and #1110; fix still pending in #1103.

Resolution: closed superseded

Reason: Maintainer asanvaq asked to keep the changes separate and continue with #1103/#1110; author gcomneno then closed #1117 confirming the work is already covered there. No commits from this PR landed — rockcraft/commands/extensions.py:88 still reads "Expand extensions in snapcraft.yaml" at HEAD.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #658. `rockcraft help --all` listed `expand-extensions` as expanding extensions in `snapcraft.yaml`. This updates the command help text to correctly reference `rockcraft.yaml`. No functional changes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Docs-only PR correcting the expand-extensions help text to say rockcraft.yaml. Closed unmerged by the author after maintainer @asanvaq noted it duplicated the work in #1103 and #1110; fix still pending in #1103.
stealth/space-bunny-alpha — closed superseded Closed unmerged as redundant: the author redirected the expand-extensions help-text fix to #1103 and #1110 after maintainer feedback to keep the changes separate.
qwen/qwen3.6-35b-a3b — — Closed and abandoned as it duplicated work from PRs #1103 and #1110. The author redirected the help text fix for the expand-extensions command into those separate PRs per reviewer feedback to keep changes distinct.
qwen3.6-35b-a3b-mtp-q6 — — Closed as superseded. The CLI help text fix duplicates PRs #1103 and #1110. Author closed this PR per reviewer feedback to maintain separation of changes.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#658 (confidence 95%)

    Original issue this PR claimed to fix; still open since the help text at HEAD still references snapcraft.yaml.

  • Superseded By: canonical/rockcraft#1103 (confidence 93%)

    Cited by both maintainer and author as the PR carrying this fix; approved with CI green but still open, so the correction is not yet in main.

  • Duplicate Of: canonical/rockcraft#1103 (confidence 80%)

    #1117 duplicated the same one-line help text change from snapcraft.yaml to rockcraft.yaml in rockcraft/commands/extensions.py.

  • Duplicate Of: canonical/rockcraft#885 (confidence 70%)

    Earlier approved PR making the same one-line removal of the snapcraft.yaml reference, now itself superseded by #1103.

  • Related To: canonical/rockcraft#1110 (confidence 45%)

    Named alongside #1103 by the maintainer as containing overlapping work, though its own scope is a separate docs change.

Related issues

Issue Project State Summary Similarity
#1111 Fix expand-extensions help text to reference rockcraft.yaml rockcraft closed Closed unmerged as a duplicate of #1103, which included the same rockcraft.yaml help-text correction and additional overview wording fixes.
86%
#1210 fix(commands): reference rockcraft.yaml in extensions help rockcraft closed PR #1210 (fix expand-extensions help to say rockcraft.yaml instead of snapcraft.yaml) was closed unmerged by its author as a duplicate of canonical/rockcraft#1103, which is already approved and CI-passing.
86%
#658 Help includes expand-extensions entry with reference to snapcraft.yaml rockcraft open rockcraft help --all shows 'expand-extensions: Expand extensions in snapcraft.yaml', a copy-paste leftover; rockcraft.yaml is the correct file. Still present at HEAD; fixes #885/#1103 approved but unmerged.
81%
#1103 fix: remove snapcraft.yaml reference from expand-extensions rockcraft open Two-line help/docstring fix in rockcraft/commands/extensions.py replacing "snapcraft.yaml" with "rockcraft.yaml" in expand-extensions. Approved, CI passing, no unresolved comments; verified still applicable to current main.
79%
#289 docs: expand rockcraft.yaml reference rockcraft merged Merged into main via commit 654c9c01, reorganizing reference docs and expanding the rockcraft.yaml configuration reference across seven files.
76%
#1370 docs: explain Rockcraft extensions and their usage rockcraft closed PR #1370 was closed unmerged after approval; no closing reason or merge commit was recorded, and the files lint check remained pending.
75%
#293 Improve reference docs for rockcraft commands rockcraft open CLI reference expansion was delivered by PR #318; follow-up consolidation in #1354 is also closed, leaving no active work tracked here.
74%
#1057 fix(schema): allow extensions field in rockcraft.yaml rockcraft merged Merged as commit 23fe7dfe, adding the extensions field to the rockcraft.yaml schema and fixing IDE validation reported in canonical/rockcraft#922.
74%
#1082 fix: reference slug path in for rockcraft.yaml #2 rockcraft merged Merged in canonical/rockcraft#1082 via commit cae91c7d, correcting the CLI’s rockcraft.yaml reference link to the documentation slug rockcraft-yaml.
72%
#682 docs: fix typo rockcraft merged Merged rockcraft#682 (commit 371bc723) fixing a one-line documentation typo; approved by 3 reviewers, CLA signed, merged.
72%