← Back to issue list

fix(cli): refer to rockcraft.yaml in expand-extensions help

View original Github issue

Metadata

Project
rockcraft
Number
#1117
Type
pull request
State
closed
Author
gcomneno
Labels
Created
Updated
Closed

Current evaluation

Closed and abandoned as it duplicated work from PRs #1103 and #1110. The author redirected the help text fix for the expand-extensions command into those separate PRs per reviewer feedback to keep changes distinct.

Suggested action:

No scores available.

Issue body

Fixes #658. `rockcraft help --all` listed `expand-extensions` as expanding extensions in `snapcraft.yaml`. This updates the command help text to correctly reference `rockcraft.yaml`. No functional changes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed and abandoned as it duplicated work from PRs #1103 and #1110. The author redirected the help text fix for the expand-extensions command into those separate PRs per reviewer feedback to keep changes distinct.
qwen3.6-35b-a3b-mtp-q6 Closed as superseded. The CLI help text fix duplicates PRs #1103 and #1110. Author closed this PR per reviewer feedback to maintain separation of changes.
qwen3.6-35b-a3b-mtp-q6 Closed as superseded. The help text fix for expand-extensions to reference rockcraft.yaml was duplicated in PRs #1103 and #1110. Author closed this PR per reviewer feedback to consolidate changes and continue work in the other PRs.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1210 fix(commands): reference rockcraft.yaml in extensions help rockcraft closed Closed as a duplicate of PR #1103, which already implements the same help text fix and is approved. The change to reference rockcraft.yaml instead of snapcraft.yaml in the expand-extensions command is handled by the superseding pull request.
85%
#1111 Fix expand-extensions help text to reference rockcraft.yaml rockcraft closed Superseded by PR #1103 to avoid duplication. The author and maintainer agreed to proceed with the other PR instead, closing this one without merging.
84%
#658 Help includes expand-extensions entry with reference to snapcraft.yaml rockcraft open rockcraft help --all shows expand-extensions referencing snapcraft.yaml instead of rockcraft.yaml. Bug still present in code; two approved but unmerged PRs (#885, #1103) fix the help text. Labeled good first issue, no maintainer activity since 2024.
77%
#289 docs: expand rockcraft.yaml reference rockcraft merged Merged after three reviewers approved, the PR reorganized the documentation reference section and expanded the rockcraft.yaml reference guide, modifying 7 files.
72%
#1417 fix: expand-extensions overview charmcraft merged Merged into main. This pull request fixes the expand-extensions overview for the craft-application based command, mirroring PR #1416. Approved by two reviewers with passing CI checks, the change modifies one file with five additions and two deletions.
71%