← Back to issue list

feat(extensions): add Django framework V2 extension and factory dispatch

View original Github issue

Metadata

Project
rockcraft
Number
#1255
Type
pull request
State
closed
Author
Thanhphan1147
Labels
—
Created
Updated
Closed

Current evaluation

PR closed as redundant: its Django V2 extension and factory dispatch changes were folded into base PR #1259, which merged to main as commit 644c6950 (feat(extensions): extension dispatch for 12-factor extensions).

Resolution: closed superseded

Reason: The author closed #1255 after merging its contents into canonical/rockcraft#1259, which was merged as commit 644c6950. That commit introduced _FrameworkFactory dispatch and DjangoFrameworkFactory = _FrameworkFactory(DjangoFramework, DjangoFrameworkV2) in rockcraft/extensions/gunicorn.py, now present on main.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add DjangoFrameworkV2 (targets ubuntu@26.04, inherits DjangoFramework) and a DjangoFrameworkFactory that dispatch the V1 or V2 extension class depending on the base. Implements ISD283 (internal) for the django-framework extension. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR closed as redundant: its Django V2 extension and factory dispatch changes were folded into base PR #1259, which merged to main as commit 644c6950 (feat(extensions): extension dispatch for 12-factor extensions).
stealth/space-bunny-alpha — closed superseded Django V2 factory-dispatch changes were folded into merged PR #1259, which landed in commit 644c6950.
qwen/qwen3.6-35b-a3b — — Superseded and closed. Changes were merged into base PR #1259 to consolidate reviews. The Django V2 extension and factory dispatch implementation is now tracked in the referenced pull request.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1259 (confidence 99%)

    Base PR that absorbed these changes; merged as commit 644c6950 adding _FrameworkFactory dispatch and V2 framework classes.

  • Related To: canonical/rockcraft#1320 (confidence 45%)

    Follow-up work on the same V2 12-factor framework extensions (bare base support) built on the dispatch landed in 644c6950.

Related issues

Issue Project State Summary Similarity
#1254 feat(extensions): add Flask framework V2 extension and factory dispatch rockcraft closed PR closed as redundant: the author moved the FlaskFrameworkV2 and FlaskFrameworkFactory changes into base PR #1259, which merged as commit 644c6950 ('feat(extensions): extension dispatch for 12-factor extensions'), covering all five framework V2 extensions.
87%
#1259 feat(extensions): extension dispatch for 12-factor extensions. rockcraft merged Merged as commit 644c6950, adding _FrameworkFactory dispatch plus V2 extension classes (Flask, Django, FastAPI, ExpressJS, SpringBoot) targeting ubuntu@26.04; extended later by #1320/#1332/#1345/#1364.
81%
#1257 feat(extensions): add ExpressJS framework V2 extension and factory dispatch rockcraft closed ExpressJS V2 extension + factory dispatch were folded into base PR #1259, merged as commit 644c6950; this PR was closed as redundant.
80%
#1258 feat(extensions): add SpringBoot framework V2 extension and factory dispatch rockcraft closed PR closed unmerged: author moved the SpringBootFrameworkV2 + SpringBootFrameworkFactory dispatch changes into base PR #1259, which was merged in commit 644c6950 covering V2 dispatch for 12-factor extensions.
79%
#1256 feat(extensions): add FastAPI framework V2 extension and factory dispatch rockcraft closed FastAPI V2 and factory-dispatch work was folded into #1259 and merged as 644c6950; standalone PR #1256 was closed to reduce review overhead.
77%