← Back to issue list

feat(extensions): add FastAPI framework V2 extension and factory dispatch

View original Github issue

Metadata

Project
rockcraft
Number
#1256
Type
pull request
State
closed
Author
Thanhphan1147
Labels
—
Created
Updated
Closed

Current evaluation

FastAPI V2 and factory-dispatch work was folded into #1259 and merged as 644c6950; standalone PR #1256 was closed to reduce review overhead.

Resolution: closed superseded

Reason: The author confirmed that #1256's changes were incorporated into base PR canonical/rockcraft#1259. That PR merged to main as commit 644c6950, superseding the standalone PR.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add FastAPIFrameworkV2 (targets ubuntu@26.04, inherits FastAPIFramework) and a FastAPIFrameworkFactory that dispatch the V1 or V2 extension class depending on the base. Implements ISD283 (internal) for the fastapi-framework extension. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded FastAPI V2 and factory-dispatch work was folded into #1259 and merged as 644c6950; standalone PR #1256 was closed to reduce review overhead.
stealth/space-bunny-alpha — closed superseded Superseded by canonical/rockcraft#1259, which merged the FastAPI V2 dispatch work in commit 644c6950.
stealth/space-bunny-alpha — closed superseded PR closed unmerged: its FastAPI V2 extension and factory-dispatch work was folded into canonical/rockcraft#1259, which merged as commit 644c6950 adding V2 extension classes for 12-factor extensions.
stealth/space-bunny-alpha — closed superseded PR closed unmerged; its FastAPI V2 extension and factory-dispatch code was folded into canonical/rockcraft#1259, which merged as commit 644c6950.
stealth/space-bunny-alpha — closed superseded FastAPI V2 extension and factory-dispatch changes were folded into canonical/rockcraft#1259, which merged as 644c6950; the standalone PR was closed.
qwen/qwen3.6-35b-a3b — — Closed and superseded. Changes were merged into base PR #1259 to reduce review overhead, with the author directing reviewers to that PR instead.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1259 (confidence 100%)

    The base PR incorporated these changes and merged as commit 644c6950.

Related issues

Issue Project State Summary Similarity
#1254 feat(extensions): add Flask framework V2 extension and factory dispatch rockcraft closed PR closed as redundant: the author moved the FlaskFrameworkV2 and FlaskFrameworkFactory changes into base PR #1259, which merged as commit 644c6950 ('feat(extensions): extension dispatch for 12-factor extensions'), covering all five framework V2 extensions.
80%
#1257 feat(extensions): add ExpressJS framework V2 extension and factory dispatch rockcraft closed ExpressJS V2 extension + factory dispatch were folded into base PR #1259, merged as commit 644c6950; this PR was closed as redundant.
79%
#1259 feat(extensions): extension dispatch for 12-factor extensions. rockcraft merged Merged as commit 644c6950, adding _FrameworkFactory dispatch plus V2 extension classes (Flask, Django, FastAPI, ExpressJS, SpringBoot) targeting ubuntu@26.04; extended later by #1320/#1332/#1345/#1364.
77%
#1255 feat(extensions): add Django framework V2 extension and factory dispatch rockcraft closed PR closed as redundant: its Django V2 extension and factory dispatch changes were folded into base PR #1259, which merged to main as commit 644c6950 (feat(extensions): extension dispatch for 12-factor extensions).
77%
#1258 feat(extensions): add SpringBoot framework V2 extension and factory dispatch rockcraft closed PR closed unmerged: author moved the SpringBootFrameworkV2 + SpringBootFrameworkFactory dispatch changes into base PR #1259, which was merged in commit 644c6950 covering V2 dispatch for 12-factor extensions.
74%