Rebase "rockcraft pack" onto craft-application framework
Metadata
Current evaluation
Rebased rockcraft pack onto craft-application in PR #354 (8d74e452); PR #395 later merged feature/craft-application into main, completing the migration to craft-application 1.0.0.
Resolution: closed resolved
Reason: PR #354 implemented the CraftApplication-based pack command in commit 8d74e452. PR #395 subsequently merged the feature branch into main, completing the migration.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
The craft-application framework reduces repeated code from various *craft applications. Rockcraft should be rebased onto craft-application before we get a stable release.
### Why it needs to get done
Reduce repeated code throughout the *craft applications.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Rebased rockcraft pack onto craft-application in PR #354 (8d74e452); PR #395 later merged feature/craft-application into main, completing the migration to craft-application 1.0.0. | |
| stealth/space-bunny-alpha | — | closed resolved | "rockcraft pack" moved to craft-application in PR #354 (commit 8d74e452); PR #395 later integrated the feature branch into main, completing the craft-application 1.0.0 migration. | |
| stealth/space-bunny-alpha | — | closed resolved | Rockcraft pack was migrated to craft-application by merged PR #354 (commit 8d74e452); PR #395 later merged the feature branch into main with craft-application 1.0.0. | |
| stealth/space-bunny-alpha | — | closed resolved | Migration to craft-application completed: PR #354 (commit 8d74e452) moved "rockcraft pack" onto CraftApplication on the feature branch, and PR #395 merged that branch into main with craft-application 1.0.0. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #354 moved rockcraft pack to craft-application; PR #395 later merged the feature branch into main, completing the migration to craft-application 1.0.0. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged via PR #354 into a feature branch. The rockcraft pack command was rebased onto the craft-application framework to reduce code duplication across craft tools. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into a feature branch via PR #354. The rockcraft pack command was rebased onto the craft-application framework to reduce code duplication across craft applications. | |
| qwen/qwen3.6-35b-a3b | — | — | Rockcraft pack was rebased onto the craft-application framework. The work was merged into pull request #354, but applied to a feature branch instead of the main line. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Rebasing rockcraft pack onto the craft-application framework was merged into a feature branch via pull request #354. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/rockcraft#354
(confidence 100%)
Merged PR implementing CraftApplication for the pack command.
-
Likely Fixed By:
canonical/rockcraft#395
(confidence 100%)
Merged feature/craft-application into main to complete the migration.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #354 refactor: use craft-application for "pack" | rockcraft | merged | Merged #354 routed rockcraft pack through the CraftApplication runner (commit 8d74e452); its feature branch was later integrated into main by #395. | |
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged as commit 2139bcd2: refactored Rockcraft onto craft-application 5 (49 files, +959/-915) after approval from 3 reviewers; later bumped to craft-application 6.0 via #1027. | |
| #1350 Move Rockcraft to the craft-application mediation framework | rockcraft | closed | Closed after ROCKCRAFT-319 was filed; no PR linked. Related commit 0b6ba8bd (PR #1357, 'skip repacking if project is unchanged') implements the no-repack goal. | |
| #346 Prototype Rockcraft Rebase | rockcraft | closed | Prototype closed without a recorded resolution; the broader migration later landed via #856 (2139bcd2), using Craft Application 5. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs. | |
| #1133 Rebase Charmcraft onto craft-application | charmcraft | closed | Tracking issue for rebasing Charmcraft onto craft-application; delivered by merged PR #1399 'feat: craft-application rebase' (commit 3ba803d1, CRAFT-2239), a 109-file rewrite of the CLI foundation. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues. | |
| #1027 build(deps): update craft-application to 6.0 | rockcraft | merged | Merged PR #1027 as commit bfa24b25, upgrading craft-application to 6.0 so Rockcraft could use ubuntu@26.04 as its devel base. | |
| #485 Update to craft-application@main | rockcraft | merged | Merged in PR #485, updating to craft-application@main; three commits added BuildPlanner work and removed obsolete Rockcraft code. | |
| #359 Migrate remaining lifecycle commands to craft-application | rockcraft | closed | Resolved by rockcraft PR #395, merged into main; commits e28d53f7 and 0b44fd60 removed legacy lifecycle commands and completed the craft-application migration. |