← Back to issue list

style: ruff 0.16

View original Github issue

Metadata

Project
starbase
Number
#582
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged starbase#582 ("style: ruff 0.16", +1/-0) by maintainer mr-cal, adding PLR0917 (too many positional arguments) to the per-file Ruff ignores for tests.

Resolution: closed resolved

Reason: PR #582 was approved by 2 reviewers and merged into main with all CI checks passing; the single-line change adds "tests/**" per-file-ignores for PLR0917 in the Ruff config to accommodate the new rule in ruff 0.16.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Ignore [PLR0917](https://docs.astral.sh/ruff/rules/too-many-positional-arguments/) for tests. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged starbase#582 ("style: ruff 0.16", +1/-0) by maintainer mr-cal, adding PLR0917 (too many positional arguments) to the per-file Ruff ignores for tests.
stealth/space-bunny-alpha — closed resolved Merged starbase#582, adding a Ruff 0.16 configuration to ignore PLR0917 (too many positional arguments) in tests.
qwen/qwen3.6-35b-a3b — — Merged following two approvals and successful CI checks. Updates ruff to 0.16 and adds a configuration to ignore the PLR0917 rule for tests.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 5
Confidence: 95
needs review Updates ruff configuration to version 0.16 and ignores PLR0917 in tests. Approved by one reviewer, all CI checks passing, and ready for maintainer merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Updates ruff configuration to version 0.16 and ignores the PLR0917 rule for test files. All CI checks pass, and the PR has one approval with no unresolved comments.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Updates ruff configuration to version 0.16 and ignores the PLR0917 rule for tests. All CI checks pass. Currently awaiting maintainer review.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#165 style: fix linting for ruff 0.12 imagecraft merged Merged #165, incorporating canonical/starbase#408, with a four-file Ruff 0.12 compatibility style update (+7/-7).
82%
#5343 style: ruff 0.11 fixes snapcraft merged Merged Ruff 0.10/0.11 style fixes in #5343, changing two lines in one file, via merge commit ce88542d5.
79%
#5574 style: ruff 0.12 snapcraft merged Merged Ruff 0.12 compatibility and style updates in commit 94a594fd3 after approval by two reviewers.
79%
#1323 style: fix new ruff warnings rockcraft merged PR #1323 merged to main: hand-fixed minor new Ruff warnings in 3 files (+30/-20). Lint and all test suites passed; only source-spread-tests failed (unrelated to style change).
75%
#415 style: fix ruff 0.16 warning craft-store merged Merged PR #415 as commit b24d684, adding a directive to ignore Ruff 0.16's new warning; all CI checks passed.
75%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
75%
#55 lint: stricter ruff rules starbase merged Merged PR canonical/starbase#55 as b5cda0d, tightening Ruff lint rules in one file (+23/-9) after maintainer approval.
75%
#20 style: fix ruff issue craft-platforms merged Merged PR #20 fixed a Ruff linting issue in one file (+1/-3); resolution is commit 71a165d.
74%
#263 tools: add ruff config rockcraft merged Merged PR #263 added Starbase’s Ruff configuration and a Makefile test-ruff target; merged as commit 4abd39c2.
74%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
74%