← Back to issue list

style: ruff 0.16

View original Github issue

Metadata

Project
starbase
Number
#582
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged following two approvals and successful CI checks. Updates ruff to 0.16 and adds a configuration to ignore the PLR0917 rule for tests.

Suggested action: —

No scores available.

Issue body

Ignore [PLR0917](https://docs.astral.sh/ruff/rules/too-many-positional-arguments/) for tests. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged following two approvals and successful CI checks. Updates ruff to 0.16 and adds a configuration to ignore the PLR0917 rule for tests.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 5
Confidence: 95
needs review Updates ruff configuration to version 0.16 and ignores PLR0917 in tests. Approved by one reviewer, all CI checks passing, and ready for maintainer merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Updates ruff configuration to version 0.16 and ignores the PLR0917 rule for test files. All CI checks pass, and the PR has one approval with no unresolved comments.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Updates ruff configuration to version 0.16 and ignores the PLR0917 rule for tests. All CI checks pass. Currently awaiting maintainer review.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#409 style(ruff): disable PLW1641 starbase merged Merged after two approvals and passing CI checks. Disables the Ruff PLW1641 (eq-without-hash) lint rule via a single configuration change. Related lint fixes were handled in PRs #410 and #411.
82%
#5574 style: ruff 0.12 snapcraft merged Merged after two reviewer approvals. Updates codebase for ruff 0.12 compatibility. CI passed except a non-blocking OSV-scanner failure. Changes affect 8 files with 56 additions and 23 deletions.
81%
#5343 style: ruff 0.11 fixes snapcraft merged Merged minor style updates to align with ruff 0.10 and 0.11. Approved by two reviewers, passed CI checks, and merged with minimal changes across one file.
81%
#6378 style: ruff 0.16 snapcraft merged Merged housekeeping updates: ruff 0.16 configuration, cryptography CVE fix, and removal of an outdated maturin constraint. Approved by two reviewers and passed CI checks prior to merge.
81%
#415 style: fix ruff 0.16 warning craft-store merged Merged after two approvals and passing CI. Resolved a ruff 0.16 warning by adding an ignore directive copied from Starbase. The change added a single line to one file.
80%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
80%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment.
80%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
79%
#236 build: update ruff settings craft-cli merged Merged following approval from two reviewers and passing CI checks. The change updates ruff configuration settings with a five-line modification to align linting rules.
79%
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
78%