← Back to issue list

Migrate lifecycle commands

View original Github issue

Metadata

Project
rockcraft
Number
#366
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged lifecycle-command migration in Rockcraft PR #366 (commit e28d53f7), replacing legacy lifecycle commands with craft-application implementations.

Resolution: closed resolved

Reason: PR #366 was merged after approval from three reviewers. Resolving commit e28d53f7 records the lifecycle-command migration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged lifecycle-command migration in Rockcraft PR #366 (commit e28d53f7), replacing legacy lifecycle commands with craft-application implementations.
stealth/space-bunny-alpha — closed resolved Merged Charmcraft PR #1538, commit 5e3b927c, migrated lifecycle commands to craft-application implementations, advancing #1532.
qwen/qwen3.6-35b-a3b — — Migrated lifecycle commands across 42 files, reducing code by 2672 lines and adding 563. Approved by three reviewers and merged after resolving 16 review comments.
qwen3.6-35b-a3b-mtp-q6 — — The lifecycle commands migration was merged by maintainer tigarmo. Accepted without review comments, the change was integrated into the codebase.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#1538 (confidence 90%)

    Upstream Charmcraft migration, commit 5e3b927c, supplied the craft-application implementations used here.

Related issues

Issue Project State Summary Similarity
#359 Migrate remaining lifecycle commands to craft-application rockcraft closed Resolved by rockcraft PR #395, merged into main; commits e28d53f7 and 0b44fd60 removed legacy lifecycle commands and completed the craft-application migration.
92%
#1532 Use craft-application lifecycle commands charmcraft closed Most bespoke lifecycle commands were replaced with craft-application's upstream commands by merged PR #1538 (commit 5e3b927c); pack cleanup followed in #1704 (cfc37020).
77%
#1412 Use upstream craft-application lifecycle commands charmcraft closed Lifecycle migration completed by PR #1538 (5e3b927c); PR #1704 (cfc37020) finished the remaining pack migration cleanup using upstream craft-application commands.
76%
#360 Migrate non-lifecycle commands to craft-application rockcraft closed Resolved by merged PR #761 (commit 484099f5), which adopted craft-application’s upstream Init command/service and added --project-dir support.
75%
#1284 Migrate store commands to craft-application charmcraft closed Store commands were migrated to craft-application in merged PR #1358 (commit 5cb01186); commit 9da46c37 later removed the unused legacy implementations.
71%
#1538 chore: replace most lifecycle commands with upstream ones charmcraft merged Merged as commit 5e3b927c, replacing most lifecycle commands with craft-application upstream commands; pack extension remained outstanding.
70%