← Back to issue list

Migrate non-lifecycle commands to craft-application

View original Github issue

Metadata

Project
rockcraft
Number
#360
Type
issue
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Resolved by merged PR #761 (commit 484099f5), which adopted craft-application’s upstream Init command/service and added --project-dir support.

Resolution: closed resolved

Reason: PR #761 merged into Rockcraft as commit 484099f5, replacing Rockcraft’s init implementation with craft-application’s upstream command and service.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Migrate the extensions and the `init` command to craft-application. ### Why it needs to get done For parity!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #761 (commit 484099f5), which adopted craft-application’s upstream Init command/service and added --project-dir support.
stealth/space-bunny-alpha — closed resolved Rockcraft’s `init` migration was delivered by PR #761, commit 484099f5, adopting craft-application’s upstream Init command and service with `--project-dir` support.
qwen/qwen3.6-35b-a3b — — Closed without a documented resolution. Implementation discussion noted changing the InitCommand superclass from BaseCommand to AppCommand within craft-application. The migration remains unimplemented and effectively abandoned.
qwen/qwen3.6-35b-a3b — — Closed without a linked merge, likely abandoned. The migration requires updating InitCommand to inherit from AppCommand and assigning the correct CommandGroup, but no implementation was completed.
qwen/qwen3.6-35b-a3b — — Closed without implementation, likely abandoned. Discussion highlighted potential complexity with command specialization, but no migration pull request was opened or merged to transfer non-lifecycle commands to craft-application.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation. The migration of non-lifecycle commands to craft-application was discussed but never completed, indicating the task was abandoned or superseded by later architectural changes.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/rockcraft#761 (confidence 100%)

    Merged PR that completed the craft-application init migration.

Related issues

Issue Project State Summary Similarity
#1153 Move the init command to craft-application charmcraft closed Init moved to craft-application and was adopted by Charmcraft in merged PR canonical/charmcraft#1340; upstream PR canonical/craft-application#522 landed it in commit f2a4becf.
78%
#359 Migrate remaining lifecycle commands to craft-application rockcraft closed Resolved by rockcraft PR #395, merged into main; commits e28d53f7 and 0b44fd60 removed legacy lifecycle commands and completed the craft-application migration.
78%
#5098 Use upstream `init` command from craft-application snapcraft closed Snapcraft adopted craft-application's init command in merged PR #5129 (commit de05a733d), preserving behavior while adding name, profile, and project-dir options.
76%
#5129 refactor: use init command from craft-application snapcraft merged Merged PR #5129 (de05a733d) replaced Snapcraft’s init command with craft-application’s, fixed #5098, and added name, profile, and project-dir options.
75%
#366 Migrate lifecycle commands rockcraft merged Merged lifecycle-command migration in Rockcraft PR #366 (commit e28d53f7), replacing legacy lifecycle commands with craft-application implementations.
75%
#1532 Use craft-application lifecycle commands charmcraft closed Most bespoke lifecycle commands were replaced with craft-application's upstream commands by merged PR #1538 (commit 5e3b927c); pack cleanup followed in #1704 (cfc37020).
74%
#1412 Use upstream craft-application lifecycle commands charmcraft closed Lifecycle migration completed by PR #1538 (5e3b927c); PR #1704 (cfc37020) finished the remaining pack migration cleanup using upstream craft-application commands.
74%
#1340 feat(craft-app): move init command charmcraft merged PR #1340 by lengau merged, relocating charmcraft's init command into craft-application (with the init service/command/tests) plus lint fixes (+500/-343, 18 files). Later cleanup commit 97fa9229 (#1520) removed the old implementation.
73%
#4468 feature/craft-application: migrate version command snapcraft closed Version command migration to craft-application landed in merged PR #4614 (commit 885106d06), completing the work drafted in 24d48da8 and closing the tracking issue ahead of the craft-application rebase.
72%
#1520 refactor: remove old "init" command implementation charmcraft merged Merged PR #1520 in commit 97fa9229, removing 248 lines of obsolete init command code after the craft-application transition.
72%