← Back to issue list

project: add rockcraft.yaml load function (CRAFT-586)

View original Github issue

Metadata

Project
rockcraft
Number
#8
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #8 added a dedicated rockcraft.yaml loader with tests; merge commit 3cf2d6fa contains implementation commit 85981d00.

Resolution: closed resolved

Reason: PR #8 was approved and merged as commit 3cf2d6fa, with implementation commit 85981d00. It refactored project-file loading into a separate function and added tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Move project file loading to a separate function with tests. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #8 added a dedicated rockcraft.yaml loader with tests; merge commit 3cf2d6fa contains implementation commit 85981d00.
stealth/space-bunny-alpha — closed resolved Merged PR #8 added a dedicated rockcraft.yaml loader with tests, moving project-file loading into a separate function. Implementation: 85981d00; merge: 3cf2d6fa.
stealth/space-bunny-alpha — closed resolved Merged PR #8, adding a dedicated rockcraft.yaml loader with tests and moving project-file loading into it (+89/-19 across four files).
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI checks. Extracts project file loading into a dedicated function with tests, modifying four files with 89 additions and 19 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Refactored project file loading into a dedicated function with unit tests, addressing CRAFT-586. Submitted and approved by maintainer cmatsuoka.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6 project: add basic rockcraft.yaml parsing and validation (CRAFT-584) rockcraft merged Merged in rockcraft PR #6 (88c9d529), adding rockcraft.yaml parsing and parts validation, renaming tag to version, and switching output from .oci.tar to .rock.
83%
#474 feat: build Rockcraft rock rockcraft closed PR adding rockcraft.yaml to pack Rockcraft itself as a rock (plus a GHCR workflow) was closed unmerged by author cjdcordeiro; no rockcraft.yaml commit landed in rockcraft.
76%
#289 docs: expand rockcraft.yaml reference rockcraft merged Merged into main via commit 654c9c01, reorganizing reference docs and expanding the rockcraft.yaml configuration reference across seven files.
74%
#40 feat(rockcraft-pack): support rockcraft test craft-actions merged Merged #40 as commit 05e3417, adding rockcraft test support to rockcraft-pack so test workflows can reuse the action's packed rock.
73%
#372 Merge `rockcraft` craft-application merged PR #372 merged into the temporary 2.x branch, adding reviewed rockcraft work and commit ccfe498d's corrected craft-cli/craft-parts constraints for the planned 2.9.0 release.
73%
#105 docs: add commands rockcraft merged Merged PR #105 as commit 68906471, adding the first draft of rockcraft command documentation and resolving issue #101.
72%
#1056 docs: clean up 'rockcraft.yaml' rockcraft merged Merged PR #1056 as commit 32d800b9, upgrading pydantic-kitbash to v0.1.1 and cleaning rockcraft.yaml docs by removing redundant modules and normalizing field order.
71%
#939 feat: add entrypoint-command rockcraft merged Merged PR rockcraft#939 (commit 0f919f9a) adding the `entrypoint-command` project key to rockcraft.yaml, letting rocks override the default `pebble enter` OCI entrypoint; shipped in Rockcraft 1.14.
71%
#400 fix(docs): make sure we can build the example rockcraft.yaml rockcraft merged Merged in e7e3091e: corrected the documented example to use armhf and added a spread test verifying that rockcraft.yaml builds.
71%
#52 feat: add support for the "platforms" primitive rockcraft merged Merged PR canonical/rockcraft#52 (commit 9f4269c4) added the 'platforms' primitive to rockcraft.yaml, implementing multi-architecture build syntax requested in issue #49, which is now closed.
70%