project: add rockcraft.yaml load function (CRAFT-586)
Metadata
Current evaluation
Merged after approval and passing CI checks. Extracts project file loading into a dedicated function with tests, modifying four files with 89 additions and 19 deletions.
Suggested action: —
No scores available.
Issue body
Move project file loading to a separate function with tests.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI checks. Extracts project file loading into a dedicated function with tests, modifying four files with 89 additions and 19 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Refactored project file loading into a dedicated function with unit tests, addressing CRAFT-586. Submitted and approved by maintainer cmatsuoka. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged extraction of project file loading into a dedicated function with tests. Resolves CRAFT-586 by improving code modularity and adding unit tests for rockcraft.yaml parsing. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6 project: add basic rockcraft.yaml parsing and validation (CRAFT-584) | rockcraft | merged | Merged changes adding rockcraft.yaml parsing and validation to halt builds on invalid parts. Renamed the tag field to version and updated the output image suffix to .rock. Approved and passed CI across seven files. | |
| #73 refactor: make rockcraft-pack follow new call conventions | craft-actions | merged | Merged after approvals and CI. Refactored rockcraft-pack to adopt new conventions: actions in dedicated directories, tests co-located, shared logic in common/. Updated 17 files. | |
| #289 docs: expand rockcraft.yaml reference | rockcraft | merged | Merged after three reviewers approved, the PR reorganized the documentation reference section and expanded the rockcraft.yaml reference guide, modifying 7 files. | |
| #3 parts: add parts support (CRAFT-27) | rockcraft | merged | Merged after approval. Integrates craft-parts to add initial parts processing support to Rockcraft. Changes span 11 files with 375 additions and 6 deletions. Zero unresolved comments and passing CI checks. | |
| #150 docs: add contributing file | rockcraft | merged | Merged Rockcraft contribution guidelines. Added 17 lines to one file, approved by one reviewer, and completed with zero unresolved comments or CI failures. | |
| #57 feat(rockcraft): support --ignore=unmaintained | craft-actions | merged | Merged following approval from three reviewers and successful CI checks. Introduces the --ignore=unmaintained flag to rockcraft, resolving issue #52. The update modifies 9 files with 179 additions and 17 deletions. | |
| #40 feat(rockcraft-pack): support rockcraft test | craft-actions | merged | Merged to integrate rockcraft test into the build workflow. The change handles implicit pack execution to avoid OCI Factory duplication. Approved by two reviewers, passed CI, and merged with 218 additions and 12 deletions. | |
| #13 project: make build-base optional, defaults to base (CRAFT-590) | rockcraft | merged | Merged after review and CI checks, making the build-base attribute in rockcraft.yaml optional and defaulting to base when unspecified. Implementation spans three files with 42 additions and 8 deletions. | |
| #400 fix(docs): make sure we can build the example rockcraft.yaml | rockcraft | merged | Merged to resolve issue #399. Added a spread test validating the example rockcraft.yaml build process for documentation. Approved by three reviewers and passed all CI checks. | |
| #1056 docs: clean up 'rockcraft.yaml' | rockcraft | merged | Merged documentation cleanup for rockcraft.yaml. Updates include upgrading pydantic-kitbash to v0.1.1, removing unnecessary module declarations, and normalizing field order. Approved by two reviewers and merged despite unrelated snap-test failures. |