merge feature/pydantic-2
Metadata
Current evaluation
Merged feature/pydantic-2 into main, completing Rockcraft's Pydantic 2 migration and final dependency updates after two approvals.
Resolution: closed resolved
Reason: PR #672 was rebase-merged with two approvals and no unresolved comments. It consolidated migration commits f1681ea1 and 8006b153 and incorporated the final dependency updates.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR has all the commits from the pydantic 2 migration, including the final dependencies. All code has already been reviewed, and the PR itself can be rebase-merged.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged feature/pydantic-2 into main, completing Rockcraft's Pydantic 2 migration and final dependency updates after two approvals. | |
| stealth/space-bunny-alpha | — | closed resolved | Pydantic 2 migration and final dependency updates were merged after two approvals, with no unresolved review comments; 26 files changed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the pydantic 2 migration branch via rebase after two approvals and passing CI. The update modified 26 files, adding 3661 lines and removing 2150, finalizing the migration and dependency updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged via rebase after consolidating all pydantic 2 migration commits and final dependencies. The maintainer completed the framework upgrade following prior code review. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/rockcraft#663
(confidence 98%)
Earlier merged Pydantic 2 migration PR whose work was consolidated into #672 and which fixed #657.
-
Related To:
canonical/rockcraft#657
(confidence 90%)
Underlying issue addressed by the Pydantic 2 migration work included in #672.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #663 chore!: migrate to pydantic 2 | rockcraft | merged | Merged PR #663 migrated Rockcraft to Pydantic 2, adopted craft-application's Platform, and fixed #657; migration work includes commit f1681ea1. | |
| #657 Migrate to Pydantic 2 | rockcraft | closed | Rockcraft was migrated to Pydantic 2 by merged PR #663, which updated the models and removed the redundant Platform model. | |
| #173 feat: upgrade to pydantic 2.x | craft-application | closed | Closed unmerged after the Pydantic 2 migration landed via craft-application#401 (c2f0978a); maintainer lengau credited #173 as helpful during that migration. | |
| #103 feat: upgrade to pydantic 2.x | craft-archives | merged | Merged PR #103 as commit b69f44a, upgrading craft-archives to Pydantic 2.x after three approvals; residual review feedback was moved to #118. | |
| #110 Migrate to Pydantic 2 | craft-archives | closed | Pydantic 2 migration was completed in merged PR #103 (commit b69f44a) on feature/2.0; the branch later reached main through PR #123. | |
| #408 chore!: merge pydantic 2 feature branch to main | craft-application | merged | Merged into main via c3aae96c, making Pydantic 2 required and incorporating final typing fixes from 25ea79c; the change is explicitly breaking. |