← Back to issue list

merge feature/pydantic-2

View original Github issue

Metadata

Project
rockcraft
Number
#672
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged the pydantic 2 migration branch via rebase after two approvals and passing CI. The update modified 26 files, adding 3661 lines and removing 2150, finalizing the migration and dependency updates.

Suggested action:

No scores available.

Issue body

This PR has all the commits from the pydantic 2 migration, including the final dependencies. All code has already been reviewed, and the PR itself can be rebase-merged.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the pydantic 2 migration branch via rebase after two approvals and passing CI. The update modified 26 files, adding 3661 lines and removing 2150, finalizing the migration and dependency updates.
qwen3.6-35b-a3b-mtp-q6 Merged via rebase after consolidating all pydantic 2 migration commits and final dependencies. The maintainer completed the framework upgrade following prior code review.
qwen3.6-35b-a3b-mtp-q6 Merged via rebase after consolidating all pydantic 2 migration commits and final dependency updates. Code was previously reviewed, requiring no additional comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#60 Migrate to pydantic 2 imagecraft merged Merged after approval. The codebase was migrated to Pydantic V2 with updated craft libraries. Changes span 27 files (+278/-340 lines) and maintain 98% test coverage, resolving FR-8917.
81%
#408 chore!: merge pydantic 2 feature branch to main craft-application merged Merged the pydantic 2 feature branch into main, upgrading the codebase and resolving typing issues. Approved by two reviewers and passing CI checks, the merge introduces breaking changes required for the pydantic 2 dependency update.
79%
#1817 chore: merge pydantic 2 support to main charmcraft merged Merged pydantic 2 support into the main branch after approval from two reviewers. The update modifies 52 files, adding 2860 lines and removing 714, completing the dependency upgrade.
79%
#401 build!: update to pydantic 2 craft-application merged Merged to update the codebase to Pydantic 2. Approved by two reviewers and passed CI. The change modified 23 files (+531/-342). Initial test failures were resolved after the craft-grammar dependency received a corresponding update.
78%
#4955 chore!: migrate to pydantic 2 snapcraft merged Merged after two approvals and passing CI. Migrates the codebase to Pydantic 2, resolving issue #4941. The author rebased and force-pushed clean commits prior to a rebase-merge.
78%
#1777 feat(deps)!: switch to pydantic 2 charmcraft merged Merged pydantic 2 upgrade, incorporating #1776. Approved by two reviewers, the update modified 81 files with a net reduction of over 15,000 lines, completing the major version migration.
78%
#193 build(deps)!: update to pydantic 2 craft-store merged Merged to upgrade the project to pydantic 2. Approved by two reviewers, the update modified 21 files with 135 additions and 90 deletions.
78%
#103 feat: upgrade to pydantic 2.x craft-archives merged Merged the pydantic 2.x upgrade after passing CI and receiving three approvals. The maintainer moved the 13 unresolved review comments to a follow-up issue.
77%
#36 chore!: update to pydantic 2 craft-grammar merged Merged the Pydantic 2 migration across five files. Approved by two reviewers and passed CI. The maintainer manually verified the author's Canonical employment to override an automated CLA check failure before finalizing the merge.
76%
#771 chore: lift-and-shift update to pydantic 2 craft-parts merged Merged after two approvals and passing CI. The update migrates the codebase to Pydantic 2 using bump-pydantic and manual fixes. It touched 38 files (+207/-127 lines) as the initial phase of the broader dependency upgrade.
74%