← Back to issue list

feat: add improved bash completion script

View original Github issue

Metadata

Project
rockcraft
Number
#793
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged after approval by two reviewers and passing CI checks. Adds an improved bash tab-completion script, modifying four files to address CRAFT-3875.

Suggested action: —

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Adds an improved bash tab-completion script. CRAFT-3875.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after approval by two reviewers and passing CI checks. Adds an improved bash tab-completion script, modifying four files to address CRAFT-3875.
qwen3.6-35b-a3b-mtp-q6 — — Merged an improved bash tab-completion script authored by maintainer bepri. The update enhances command-line auto-completion functionality, resolving CRAFT-3875. No revisions were required prior to merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged an improved bash tab-completion script authored by maintainer bepri, resolving CRAFT-3875. The change was integrated into the main branch three days after submission.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2111 feat: add improved bash completion script charmcraft merged Merged an improved bash completion script replacing the legacy version. Approved by two reviewers, the update adds 34 lines and removes 195 across six files. Resolves CRAFT-3874.
94%
#5218 feat: add improved bash completion script snapcraft merged Merged the improved bash completion script after three approvals and passing CI checks. The update modifies seven files, reducing 47 lines to 21. Reviewers validated the changes and recommended future implementation of part name autocompletion.
86%
#86 feat: add bash completion script imagecraft merged Merged the bash completion script. Author rebased on main per reviewer request. Manual testing replaced automated spread tests due to complexity, with a known limitation tracked separately.
80%
#1390 meta: bash completion support snapcraft merged Merged after adding bash completion support for snapcraft. Approved by two reviewers with passing CI checks. The change modifies five files, adding 72 lines and removing 2.
80%
#319 feat: bash auto-completion generation craft-cli merged Merged the bash auto-completion generation feature. Approved by two reviewers, passed CI and tox, and closed issue #211. The change adds approximately 758 lines across 15 files to implement automatic shell completion generation.
77%
#453 Add in bash completion snapcraft merged Merged bash completion feature. Author addressed reviewer feedback by logging a related bug and updating the commit message per guidelines. After admin verification and final testing, the changes were approved and merged.
77%
#222 Modernize the Bash completion definition. charmcraft merged Merged updates to modernize the Bash completion definition. Approved by two reviewers, the change modifies one file (+22/-4 lines). The author noted the inability to test for missing command additions.
71%