← Back to issue list

godeps plugin does not installing the git package by itself

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1671546
Type
issue
State
closed
Author
~xavi-garcia-mena
Labels
—
Created
Updated
Closed

Current evaluation

Fixed in snapcore/snapcraft#1179, merged as commit 10c46b8ad; the godeps plugin now adds git to build-packages.

Resolution: closed resolved

Reason: Merged PR #1179 added git to the godeps plugin's build-packages, ensuring git is available for the go get invocation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This happened when building on launchpad. The godeps plugin should install git. I tried to add git in the build-packages section and it works as a workaround. This is a build example: https://code.launchpad.net/~xavi-garcia-mena/+snap/godeps-test This is the end of the build log: go: missing Git command. See https://golang.org/s/gogetcmd package github.com/rogpeppe/godeps: exec: "git": executable file not found in $PATH Command '['/bin/sh', '/tmp/tmp2w8ecs_k', 'go', 'get', 'github.com/rogpeppe/godeps']' returned non-zero exit status 1 go get github.com/rogpeppe/godeps Traceback (most recent call last): File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 202, in main builder.pull() File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 139, in pull env=env) File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 92, in run_build_command self.chroot(["/bin/sh", "-c", command], echo=echo) File "/usr/share/launchpad-buildd/slavebin/buildsnap", line 66, in chroot "/usr/bin/sudo", "/usr/sbin/chroot", self.chroot_path] + args) File "/usr/lib/python2.7/subprocess.py", line 541, in check_call raise CalledProcessError(retcode, cmd) CalledProcessError: Command '['/usr/bin/sudo', '/usr/sbin/chroot', '/home/buildd/build-SNAPBUILD-26732/chroot-autobuild', 'linux32', '/bin/sh', '-c', 'cd /build/godeps-test && env LANG=C.UTF-8 https_proxy=http://snap-proxy.launchpad.net:3128 SNAPCRAFT_SETUP_CORE=1 http_proxy=http://snap-proxy.launchpad.net:3128 SNAPCRAFT_LOCAL_SOURCES=1 snapcraft pull']' returned non-zero exit status 1 Revoking proxy token... RUN: /usr/share/launchpad-buildd/slavebin/scan-for-processes ['scan-for-processes', 'SNAPBUILD-26732'] Scanning for processes to kill in build /home/buildd/build-SNAPBUILD-26732/chroot-autobuild... RUN: /usr/share/launchpad-buildd/slavebin/umount-chroot ['umount-chroot', 'SNAPBUILD-26732'] Unmounting chroot for build SNAPBUILD-26732... RUN: /usr/share/launchpad-buildd/slavebin/remove-build ['remove-build', 'SNAPBUILD-26732']

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed in snapcore/snapcraft#1179, merged as commit 10c46b8ad; the godeps plugin now adds git to build-packages.
stealth/space-bunny-alpha — closed resolved Reported godeps plugin didn't install git, breaking go get on Launchpad builds. Fixed by merged PR snapcore/snapcraft#1179 (commit 10c46b8ad), adding git to the plugin's build-packages.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/snapcraft#1179 (commit 10c46b8ad), adding git to the godeps plugin's build-packages so go get works without a manual workaround.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/snapcraft#1179 (10c46b8ad), which adds git to the godeps plugin’s build-packages.
qwen/qwen3.6-35b-a3b — — Closed without a fix. The godeps plugin fails to install git automatically, causing go get to fail. Users must manually add git to build-packages as a workaround.
qwen/qwen3.6-35b-a3b — — Closed without resolution; likely abandoned. The godeps plugin fails to install git automatically, requiring a manual build-packages workaround.
qwen/qwen3.6-35b-a3b — — The godeps plugin lacks automatic git installation, causing build failures until manually added to build-packages. Closed without resolution or comments after nine years, indicating abandonment.
qwen3.6-35b-a3b-mtp-q6 — — Closed without resolution. The godeps plugin fails builds when git is missing. Users must manually add git to build-packages as a workaround. No fix or follow-up provided.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#1179 (confidence 100%)

    The merged PR added git to the godeps plugin's build-packages in commit 10c46b8ad.

Related issues

Issue Project State Summary Similarity
#1179 godeps plugin: add git to build-packages snapcraft merged Merged in canonical/snapcraft#1179 via commit 10c46b8ad, adding git to the godeps plugin’s build-packages so its go get invocation can complete.
90%
#1595981 Need a godeps plugin snapcraft (launchpad) closed Godeps plugin support was merged in snapcore/snapcraft#691 via commit a073503c0.
80%
#691 Add godeps plugin. snapcraft merged Godeps plugin merged into snapcraft via commit a073503c0 (PR #691), adding Go godeps dependency support and resolving LP bug #1595981; later enhanced by follow-up PRs.
77%
#1657212 Godeps plugin support to build only needed binaries snapcraft (launchpad) closed Godeps gained go-packages support to build selected binaries via snapcore/snapcraft PR #1057, merged as commit 81f56fd13.
77%
#1922150 godeps using seemingly invalid commit hash snapcraft (launchpad) closed Fixed by merged snapcore/snapcraft#3475 (commit a6dfe1cd2), which defaulted the unmaintained godeps plugin to Go 1.15/stable; the reporter confirmed the workaround restored CI.
75%
#1794784 Update the godeps plugin to be base aware snapcraft (launchpad) closed Godeps gained base support through snapcore/snapcraft PR #2328, implemented by commit e1393815d.
74%
#1748202 go plugin doesn't honor godeps file snapcraft (launchpad) closed Closed after a maintainer explained that Snapcraft's dedicated godeps plugin must be used; the go plugin does not consume versions from a Godeps file.
73%
#2328 godeps plugin: support for bases snapcraft merged Merged PR #2328 as commit e1393815d, adding base-aware godeps support that prefers the Go snap and can install golang-go as a build package.
70%