← Back to issue list

Update the godeps plugin to be base aware

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1794784
Type
issue
State
closed
Author
~sergiusens
Labels
18.10-build-vm
Created
Updated
Closed

Current evaluation

Godeps gained base support through snapcore/snapcraft PR #2328, implemented by commit e1393815d.

Resolution: closed resolved

Reason: The maintainer linked PR #2328 as the resolution, and commit e1393815d records the merged godeps plugin base-support changes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update the plugin to be base aware.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Godeps gained base support through snapcore/snapcraft PR #2328, implemented by commit e1393815d.
stealth/space-bunny-alpha — closed resolved Godeps base awareness was implemented and merged in canonical/snapcraft#2328 via commit e1393815d.
stealth/space-bunny-alpha — closed resolved Godeps base awareness was implemented in merged PR #2328, commit e1393815d, prioritizing the Go snap and allowing golang-go through build-packages.
qwen/qwen3.6-35b-a3b — — Closed without resolution or comments. The request to update the godeps plugin for base awareness was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without comments or resolution. The request to update the godeps plugin for base awareness appears abandoned or superseded by subsequent build system changes.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request to make the godeps plugin base aware was abandoned after no comments or activity over several years.
qwen/qwen3.6-35b-a3b — — The request to update the godeps plugin to be base aware was closed without implementation. No comments or resolution were provided, indicating the feature was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation. The request to update the godeps plugin for base awareness was abandoned due to prolonged inactivity.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#2328 (confidence 100%)

    The linked PR implemented base awareness for the godeps plugin.

Related issues

Issue Project State Summary Similarity
#1595981 Need a godeps plugin snapcraft (launchpad) closed Godeps plugin support was merged in snapcore/snapcraft#691 via commit a073503c0.
85%
#2328 godeps plugin: support for bases snapcraft merged Merged PR #2328 as commit e1393815d, adding base-aware godeps support that prefers the Go snap and can install golang-go as a build package.
84%
#691 Add godeps plugin. snapcraft merged Godeps plugin merged into snapcraft via commit a073503c0 (PR #691), adding Go godeps dependency support and resolving LP bug #1595981; later enhanced by follow-up PRs.
84%
#1650624 Update godeps plugin to use get_pull_properties snapcraft (launchpad) closed Godeps was refactored to use get_pull_properties() with updated tests; merged via snapcore/snapcraft#1000 at commit 9b8303005.
80%
#1794785 Update the go plugin to be base aware snapcraft (launchpad) closed Base awareness for the Go plugin was implemented in snapcore/snapcraft#2323 and merged as commit 45a993643.
78%
#1657212 Godeps plugin support to build only needed binaries snapcraft (launchpad) closed Godeps gained go-packages support to build selected binaries via snapcore/snapcraft PR #1057, merged as commit 81f56fd13.
75%
#1671546 godeps plugin does not installing the git package by itself snapcraft (launchpad) closed Fixed in snapcore/snapcraft#1179, merged as commit 10c46b8ad; the godeps plugin now adds git to build-packages.
74%
#1922150 godeps using seemingly invalid commit hash snapcraft (launchpad) closed Fixed by merged snapcore/snapcraft#3475 (commit a6dfe1cd2), which defaulted the unmaintained godeps plugin to Go 1.15/stable; the reporter confirmed the workaround restored CI.
73%
#1179 godeps plugin: add git to build-packages snapcraft merged Merged in canonical/snapcraft#1179 via commit 10c46b8ad, adding git to the godeps plugin’s build-packages so its go get invocation can complete.
73%
#1748202 go plugin doesn't honor godeps file snapcraft (launchpad) closed Closed after a maintainer explained that Snapcraft's dedicated godeps plugin must be used; the go plugin does not consume versions from a Godeps file.
72%