command-chain is incompatible with legacy adapter, but snapcraft doesn't say so
Metadata
Current evaluation
Added a sanity check rejecting command-chain use with the legacy app adapter in snapcore/snapcraft#2375 (commit 57c7fb8d0).
Resolution: closed resolved
Reason: Commit 57c7fb8d0, associated with PR snapcore/snapcraft#2375, verifies that command-chain is not used with the legacy adapter. The maintainer linked that PR as the fix.
Evaluated by: mr-cal-bot
No scores available.
Issue body
When using the legacy app adapter, variables required by the command chain are defined after the command chain, making it useless. Snapcraft should error out if command-chain is used in conjunction with the legacy adapter.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Added a sanity check rejecting command-chain use with the legacy app adapter in snapcore/snapcraft#2375 (commit 57c7fb8d0). | |
| stealth/space-bunny-alpha | — | closed resolved | Snapcraft now errors at build time when command-chain is combined with the legacy app adapter; fixed by merged PR #2375 (commit 57c7fb8d0), which added the sanity check and closed LP: #1798918. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2375 (57c7fb8d0) added sanity checks rejecting command-chain with the legacy app adapter, resolving LP #1798918. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without documented resolution or fix. The report requested an explicit error for command-chain with the legacy adapter, but the issue was ultimately abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed as abandoned due to inactivity. Snapcraft lacks an error for command-chain with the legacy adapter, causing variable definition failures. No fix or discussion occurred. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#2375
(confidence 100%)
Commit 57c7fb8d0 adds the requested legacy-adapter sanity check.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2375 sanity checks: verify that command-chain is not used with legacy adapter | snapcraft | merged | Merged in PR #2375 as commit 57c7fb8d0, adding sanity checks that reject command-chain with the incompatible legacy app adapter, fixing LP #1798918. | |
| #2836 meta: fix command-chain handling when Application adapter == "none" | snapcraft | closed | PR #2836 was closed unmerged on 2020-01-07 by author cjp256 in favor of a simpler back-portable PR #2853, which was merged (commit 9599497fb) and fixed adapter: none adding snapcraft-runner to command-chain. | |
| #1973173 snapcraft 7.x/edge generates command-chain executables even when all apps and hooks use adapter:none | snapcraft (launchpad) | closed | snapcraft 7.x/edge primed a command-chain wrapper even with all apps/hooks using adapter:none. Fixed by PR #3741 (commit ec190695c), released in snapcraft 7.0.1. | |
| #3741 parts: replace snapcraft command-chain with environment | snapcraft | merged | Merged #3741 as ec190695c, replacing core22 snapcraft_runner command-chain handling with command-chain and global LD_LIBRARY_PATH/PATH defaults while deprecating adapter. | |
| #2853 meta: do not set snapcraft-runner when adapter is "none" | snapcraft | merged | Merged PR #2853 fixed app metadata handling so adapter: none does not add snapcraft-runner to command-chain; full and legacy adapters still do (commit 9599497fb). | |
| #1860873 Regression: No difference between "legacy" and "full" app adapter | snapcraft (launchpad) | closed | Snapcraft's automatic wrapper/command-chain handling made adapter obsolete; merged PR #3741 (commit 46a3e90be) deprecated it. The legacy/full distinction was ultimately removed, not restored. |