← Back to issue list

go plugin: support Go modules

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1802256
Type
issue
State
closed
Author
~rogpeppe
Labels
—
Created
Updated
Closed

Current evaluation

Closed as done: Go module support landed in the successor craft-parts Go plugin (merged PR canonical/craft-parts#78, commit b5b779df), which builds from go.mod; maintainer mr-cal cited it when closing.

Resolution: closed resolved

Reason: The go plugin was merged in craft-parts via PR #78 (merge commit b5b779df, 'plugins: add go plugin'), and its docstring and docs state it is 'a plugin for go projects using go.mod'. The last comment by mr-cal closes the Launchpad issue as completed citing that PR, so the originally requested first-class Go modules support now exists.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Go modules are the new standard way of dealing with dependencies in Go. They work well, and we're using them in quite a few projects already. It would be great to have first class support for them in the Go plugin.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Closed as done: Go module support landed in the successor craft-parts Go plugin (merged PR canonical/craft-parts#78, commit b5b779df), which builds from go.mod; maintainer mr-cal cited it when closing.
stealth/space-bunny-alpha — closed resolved Go module support was added through merged PR #78 (commit fa3fe8c8), with the Go plugin later documented in commit e017c4be.
qwen/qwen3.6-35b-a3b — — Closed as completed. Go module support is already implemented in the current Go plugin. The feature was addressed and merged via canonical/craft-parts#78.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 10
Staleness: 95
Complexity: 50
Confidence: 85
Support Request: 10
close stale Feature request for first-class Go modules support in the Go plugin. Now implemented: craft-parts' go plugin is go.mod-based (craft-parts#78), and snapcraft#3133 added go.mod support to the old v1 plugin. No activity for ~8 years.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 40
Confidence: 90
Support Request: 10
close stale Request to add first-class Go modules support to the Go plugin. Unlabelled, no maintainer interaction, inactive for nearly 7 years.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 25
Confidence: 85
Support Request: 10
close stale Request to add first-class Go modules support to the Go plugin. Unlabelled, no maintainer response, inactive for nearly 7 years.
qwen3.6-35b-a3b-mtp-q6
Staleness: 98
Complexity: 35
Confidence: 90
Support Request: 10
close stale Request to add Go modules support to the Go plugin. Unlabelled, no maintainer response, inactive for nearly 7 years.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/craft-parts#78 (confidence 85%)

    PR that added the go.mod-based Go plugin; cited verbatim by the closing maintainer comment. Merge commit b5b779df, implementation commit fa3fe8c8.

  • Related To: canonical/craft-parts#694 (confidence 55%)

    Later added user-facing docs for the 'go' plugin (commit e017c4be), confirming it is a documented, go.mod-only plugin.

Related issues

Issue Project State Summary Similarity
#78 plugins: add go plugin (CRAFT-48) craft-parts merged Merged into main as commit b5b779df (squash fa3fe8c8), adding craft_parts/plugins/go_plugin.py with GoPlugin, GoPluginProperties and GoPluginEnvironmentValidator, adapted from Snapcraft's V2 go plugin.
76%
#1879315 go plugin: go mod support @ golang 1.12 snapcraft (launchpad) closed Resolved by canonical/snapcraft#3133 (commit d9be0e925), adding limited go.mod support for Go 1.11/1.12 with legacy target resolution and a warning.
74%
#271 plugins: support "go generate" in go parts craft-parts merged Merged in commit 3e4a04fe: GoPlugin now runs go generate before builds, enabling code generation; released in craft-parts 1.13.0.
74%
#1061 check if sources can use `go-use` plugin craft-parts closed Resolved in canonical/craft-parts#1478 (commit e5af6aab): go-use now checks for go.mod before running and raises PartsError when it is missing.
72%
#2824 Support for go.mod snapcraft merged Merged Go module support for Snapcraft’s Go plugin in commit 1f609a357; follow-up PRs expanded compatibility and package detection.
71%
#2817 snapcraft/plugins: Add gomod plugin. snapcraft closed PR adding a standalone gomod plugin was closed unmerged on 2019-12-03 by sergiusens in favour of #2824, which added go module support to the existing Go plugin instead.
70%